Majr has uploaded a new change for review.
https://gerrit.wikimedia.org/r/243605
Change subject: Fix mw.notify not being visible if first loaded when scrolled
down
......................................................................
Fix mw.notify not being visible if first loaded when scrolled down
This regression was caused by using $().offset() on a hidden element, which
returns
the current scroll position making the script think the notification area starts
where the scroll position is, so it would not become fixed until you scroll
further.
Bug: T114606
Change-Id: Ice62cf3ea7b1a29e33baeca05d1a088a68c9a785
---
M resources/src/mediawiki/mediawiki.notification.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/05/243605/1
diff --git a/resources/src/mediawiki/mediawiki.notification.js
b/resources/src/mediawiki/mediawiki.notification.js
index f361ec8..e576ccf 100644
--- a/resources/src/mediawiki/mediawiki.notification.js
+++ b/resources/src/mediawiki/mediawiki.notification.js
@@ -394,11 +394,11 @@
.on( 'click', 'a', function ( e ) {
e.stopPropagation();
} )
- .hide();
// Prepend the notification area to the content area and save
it's object.
mw.util.$content.prepend( $area );
offset = $area.offset();
+ $area.hide();
function updateAreaMode() {
var isFloating = $window.scrollTop() > offset.top;
--
To view, visit https://gerrit.wikimedia.org/r/243605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice62cf3ea7b1a29e33baeca05d1a088a68c9a785
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Majr <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
