BBlack has submitted this change and it was merged.
Change subject: X-Client-IP regex fixup: whole string must match IP chars
......................................................................
X-Client-IP regex fixup: whole string must match IP chars
Change-Id: Ifa29eb8cb0e9adc514dd730892caea0b9ac7e8c2
---
M modules/varnish/templates/vcl/wikimedia.vcl.erb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
BBlack: Verified; Looks good to me, approved
diff --git a/modules/varnish/templates/vcl/wikimedia.vcl.erb
b/modules/varnish/templates/vcl/wikimedia.vcl.erb
index 48a1a08..7427e34 100644
--- a/modules/varnish/templates/vcl/wikimedia.vcl.erb
+++ b/modules/varnish/templates/vcl/wikimedia.vcl.erb
@@ -426,7 +426,7 @@
// If XCIP not set above, or looks invalid due to bad external XFF
// input, just alias to XRIP
- if (!req.http.X-Client-IP || req.http.X-Client-IP !~ "[0-9a-fA-F:.]+") {
+ if (!req.http.X-Client-IP || req.http.X-Client-IP !~
"^[0-9a-fA-F:.]+$") {
set req.http.X-Client-IP = req.http.X-Real-IP;
}
--
To view, visit https://gerrit.wikimedia.org/r/243881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa29eb8cb0e9adc514dd730892caea0b9ac7e8c2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
