Muehlenhoff has submitted this change and it was merged.

Change subject: memcached: move ferm rules out of the module
......................................................................


memcached: move ferm rules out of the module

This allows more fine-grained configuration of rules for the respective
roles (in a followup commit).

The ms-fe* systems are already covered by the swift-memcached ferm
service.

The ferm rules presen in silver and californium as not needed, on
those hosts memcached only listens on localhost.

This is a followup commit to finally remove the rule in the module.

Change-Id: Ib1a1595a245eb12821f8e2bad3a3db4ad72c1427
---
M modules/memcached/manifests/init.pp
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Filippo Giunchedi: Looks good to me, but someone else must approve
  Muehlenhoff: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/memcached/manifests/init.pp 
b/modules/memcached/manifests/init.pp
index efc2429..eb97ebb 100644
--- a/modules/memcached/manifests/init.pp
+++ b/modules/memcached/manifests/init.pp
@@ -60,11 +60,6 @@
         }
     }
 
-    ferm::service {'memcached':
-        proto => 'tcp',
-        port  => $port,
-    }
-
     base::service_unit { 'memcached':
         ensure         => present,
         systemd        => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/243652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1a1595a245eb12821f8e2bad3a3db4ad72c1427
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to