Ori.livneh has submitted this change and it was merged. Change subject: (bug 42982) transform the right part of the page ......................................................................
(bug 42982) transform the right part of the page In account creation, if the server-reported error included a table jQuery would operate on the wrong elements. This fix: 1. Avoids the specific JS error that halted the munging leaving the form invisible. 2. Is smarter about finding the right table to modify. 3. Doesn't hide so much of the page during munging so if JS fails the user sees something. The last means there could be some flash of content in a slow browser or on a slow connection, but I think it's worth it. I considered catching all JS errors in modifyPage() and always restoring the hidden form, but that seemed more invasive. Change-Id: Ic76887e6df2caa5223fc9ba2c8e16b004a4bd805 --- M experiments/acux/accountCreationUX.js 1 file changed, 32 insertions(+), 22 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/38494 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic76887e6df2caa5223fc9ba2c8e16b004a4bd805 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
