John Vandenberg has uploaded a new change for review. https://gerrit.wikimedia.org/r/244589
Change subject: Remove unused imports ...................................................................... Remove unused imports Use 'noqa' in cases where importing external modules which may have had side-effects that were needed. Change-Id: I0dba8cb830bbe65042f07b1e90a7189cf6b19ca6 --- M copyright_clean.py M copyright_put.py M disambredir.py M flickrripper.py M followlive.py M generate_family_file.py M imagecopy.py M imageuncat.py M inline_images.py M pagegenerators.py M panoramiopicker.py M query.py M rciw.py M simple_family.py M standardize_interwiki.py M subster.py M sum_disc.py M table2wiki.py M watchlist.py M wikipedia.py 20 files changed, 16 insertions(+), 34 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat refs/changes/89/244589/1 diff --git a/copyright_clean.py b/copyright_clean.py index 06c55db..6fbae6e 100644 --- a/copyright_clean.py +++ b/copyright_clean.py @@ -13,7 +13,6 @@ import sys import re -import time import wikipedia as pywikibot import catlib diff --git a/copyright_put.py b/copyright_put.py index 8ae0430..c325d6a 100644 --- a/copyright_put.py +++ b/copyright_put.py @@ -9,7 +9,6 @@ # Distributed under the terms of the MIT license. # -import sys import re import codecs import os diff --git a/disambredir.py b/disambredir.py index 373295a..ede6b83 100644 --- a/disambredir.py +++ b/disambredir.py @@ -12,8 +12,8 @@ # __version__ = '$Id$' # -import sys import re + import pywikibot import pagegenerators diff --git a/flickrripper.py b/flickrripper.py index d34bbe1..05d14af 100644 --- a/flickrripper.py +++ b/flickrripper.py @@ -31,7 +31,6 @@ # __version__ = '$Id$' -import sys import urllib2 from urllib import urlencode import re @@ -39,13 +38,11 @@ import hashlib import base64 import time + import wikipedia as pywikibot import config -import query -import imagerecat import upload import flickrapi # see: http://stuvel.eu/projects/flickrapi -import xml.etree.ElementTree from Tkinter import * from PIL import Image, ImageTk # see: http://www.pythonware.com/products/pil/ @@ -73,9 +70,10 @@ while not gotPhoto: try: photoInfo = flickr.photos_getInfo(photo_id=photo_id) - #xml.etree.ElementTree.dump(photoInfo) + # import xml.etree.ElementTree + # xml.etree.ElementTree.dump(photoInfo) photoSizes = flickr.photos_getSizes(photo_id=photo_id) - #xml.etree.ElementTree.dump(photoSizes) + # xml.etree.ElementTree.dump(photoSizes) gotPhoto = True except flickrapi.exceptions.FlickrError: gotPhotos = False diff --git a/followlive.py b/followlive.py index ba7a822..10fdbbf 100644 --- a/followlive.py +++ b/followlive.py @@ -17,8 +17,7 @@ import sys import datetime -import time -import traceback + import wikipedia as pywikibot import editarticle diff --git a/generate_family_file.py b/generate_family_file.py index 190a866..a80fdf3 100644 --- a/generate_family_file.py +++ b/generate_family_file.py @@ -47,9 +47,9 @@ os.path.exists = oldexists # Now we can boot the framework -import wikipedia +import wikipedia # noqa import family -import externals # check for and install needed +import externals # noqa: check for and install needed # parsing response data from BeautifulSoup import BeautifulSoup diff --git a/imagecopy.py b/imagecopy.py index 785c807..f36f645 100644 --- a/imagecopy.py +++ b/imagecopy.py @@ -84,19 +84,15 @@ # from Tkinter import * -import os import sys import re import codecs import urllib2 from urllib import urlencode -import httplib import webbrowser -import time import threading import socket import wikipedia as pywikibot -import config import pagegenerators import add_text from upload import * diff --git a/imageuncat.py b/imageuncat.py index c91775c..22b17d7 100644 --- a/imageuncat.py +++ b/imageuncat.py @@ -13,11 +13,11 @@ # # -import os import sys -import re + from datetime import datetime from datetime import timedelta + import pywikibot import pagegenerators import query diff --git a/inline_images.py b/inline_images.py index a278b9d..3cb31f4 100644 --- a/inline_images.py +++ b/inline_images.py @@ -29,7 +29,6 @@ __version__ = '$Id$' # -import re import pywikibot import pagegenerators import weblinkchecker diff --git a/pagegenerators.py b/pagegenerators.py index ed1b05f..a47c46a 100644 --- a/pagegenerators.py +++ b/pagegenerators.py @@ -24,7 +24,6 @@ import codecs import date import datetime -import time import traceback import wikipedia as pywikibot import config @@ -32,7 +31,6 @@ from pywikibot.support import deprecate_arg import catlib import userlib -import query parameterHelp = u"""\ -cat Work on all pages which are in a specific category. diff --git a/panoramiopicker.py b/panoramiopicker.py index a2c2697..967f9d4 100644 --- a/panoramiopicker.py +++ b/panoramiopicker.py @@ -12,19 +12,17 @@ # __version__ = '$Id$' -import sys import urllib2 import re import StringIO import hashlib import base64 -import time import wikipedia as pywikibot import config import imagerecat import upload -import externals # check for and install needed +import externals # noqa: check for and install needed try: import json except ImportError: diff --git a/query.py b/query.py index b6b5bf0..d575a44 100644 --- a/query.py +++ b/query.py @@ -314,7 +314,7 @@ encList += ToUtf8(item.title()) + u'|' elif item.__class__.__name__ == 'User': # delay loading this until it is needed - import userlib + import userlib # noqa encList += ToUtf8(item.name()) + u'|' else: raise pywikibot.Error(u'unknown item class %s' diff --git a/rciw.py b/rciw.py index 38d01ae..e5487db 100644 --- a/rciw.py +++ b/rciw.py @@ -30,8 +30,9 @@ import threading import re -import time + from Queue import Queue + import wikipedia as pywikibot import interwiki diff --git a/simple_family.py b/simple_family.py index 50c8624..9db0957 100644 --- a/simple_family.py +++ b/simple_family.py @@ -12,7 +12,6 @@ # Distributed under the terms of the MIT license. # -import config import family diff --git a/standardize_interwiki.py b/standardize_interwiki.py index c20299b..afe58d9 100644 --- a/standardize_interwiki.py +++ b/standardize_interwiki.py @@ -17,7 +17,6 @@ # import wikipedia as pywikibot -import config # The summary that the Bot will use. comment = { diff --git a/subster.py b/subster.py index 6a89474..d693c33 100644 --- a/subster.py +++ b/subster.py @@ -740,7 +740,7 @@ # http://www.mail-archive.com/[email protected]/msg209447.html import odf - from odf import opendocument, table, teletype + from odf import opendocument, table, teletype # noqa doc = odf.opendocument.load(StringIO.StringIO(external_buffer)) diff --git a/sum_disc.py b/sum_disc.py index dd450f5..e23972e 100644 --- a/sum_disc.py +++ b/sum_disc.py @@ -85,7 +85,6 @@ import datetime import hashlib import locale -import logging import urllib from xml.etree.cElementTree import XML # or if cElementTree not found, you can use BeautifulStoneSoup instead diff --git a/table2wiki.py b/table2wiki.py index ab97303..a6a8137 100644 --- a/table2wiki.py +++ b/table2wiki.py @@ -56,7 +56,6 @@ # import re -import time import wikipedia as pywikibot from pywikibot import i18n diff --git a/watchlist.py b/watchlist.py index 145cae0..a6cd802 100644 --- a/watchlist.py +++ b/watchlist.py @@ -24,7 +24,6 @@ # import re -import sys import pickle import os.path import time diff --git a/wikipedia.py b/wikipedia.py index 9cd3d09..9bf7944 100644 --- a/wikipedia.py +++ b/wikipedia.py @@ -158,7 +158,7 @@ import warnings import unicodedata import xmlreader -import externals # allow imports from externals +import externals # noqa: allow imports from externals from BeautifulSoup import BeautifulSoup, BeautifulStoneSoup, SoupStrainer import weakref import logging -- To view, visit https://gerrit.wikimedia.org/r/244589 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0dba8cb830bbe65042f07b1e90a7189cf6b19ca6 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: John Vandenberg <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
