Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/245545
Change subject: Avoid using (slow) jQuery hide() function in flow-initialize
......................................................................
Avoid using (slow) jQuery hide() function in flow-initialize
Change-Id: Ifb3eebd3c227c2855d1b5b40edfb9211d7732480
---
M handlebars/compiled/flow_block_topic.handlebars.php
M handlebars/compiled/flow_block_topic_moderate_post.handlebars.php
M handlebars/compiled/flow_block_topic_moderate_topic.handlebars.php
M handlebars/compiled/flow_block_topiclist.handlebars.php
M modules/flow-initialize.js
5 files changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/45/245545/1
diff --git a/handlebars/compiled/flow_block_topic.handlebars.php
b/handlebars/compiled/flow_block_topic.handlebars.php
index 22676d2..d165608 100644
--- a/handlebars/compiled/flow_block_topic.handlebars.php
+++ b/handlebars/compiled/flow_block_topic.handlebars.php
@@ -77,6 +77,7 @@
'.$sp.' <div class="flow-topic-summary-content">
'.$sp.' '.LCRun3::ch($cx, 'escapeContent',
array(array(((isset($in['revision']['content']['format']) &&
is_array($in['revision']['content'])) ? $in['revision']['content']['format'] :
null),((isset($in['revision']['content']['content']) &&
is_array($in['revision']['content'])) ? $in['revision']['content']['content'] :
null)),array()), 'encq').'
'.$sp.' </div>
+'.$sp.' <div style="clear: both;"></div>
'.$sp.' </div>
'.$sp.'' : '').'</div>
';},'flow_topic_titlebar_watch' => function ($cx, $in, $sp) {return
''.$sp.'<div class="flow-topic-watchlist flow-watch-link">
diff --git a/handlebars/compiled/flow_block_topic_moderate_post.handlebars.php
b/handlebars/compiled/flow_block_topic_moderate_post.handlebars.php
index 7274478..debb75d 100644
--- a/handlebars/compiled/flow_block_topic_moderate_post.handlebars.php
+++ b/handlebars/compiled/flow_block_topic_moderate_post.handlebars.php
@@ -73,8 +73,7 @@
'.$sp.' <span class="flow-post-meta-actions">
'.$sp.''.((LCRun3::ifvar($cx, ((isset($in['actions']['reply']) &&
is_array($in['actions'])) ? $in['actions']['reply'] : null))) ? '
<a href="'.htmlentities((string)((isset($in['actions']['reply']['url']) &&
is_array($in['actions']['reply'])) ? $in['actions']['reply']['url'] : null),
ENT_QUOTES, 'UTF-8').'"
'.$sp.'
title="'.htmlentities((string)((isset($in['actions']['reply']['title']) &&
is_array($in['actions']['reply'])) ? $in['actions']['reply']['title'] : null),
ENT_QUOTES, 'UTF-8').'"
-'.$sp.' class="mw-ui-anchor mw-ui-progressive
mw-ui-quiet"
-'.$sp.'
+'.$sp.' class="mw-ui-anchor mw-ui-progressive
mw-ui-quiet flow-reply-link"
'.$sp.' data-flow-eventlog-schema="FlowReplies"
'.$sp.' data-flow-eventlog-action="initiate"
'.$sp.' data-flow-eventlog-entrypoint="reply-post"
diff --git a/handlebars/compiled/flow_block_topic_moderate_topic.handlebars.php
b/handlebars/compiled/flow_block_topic_moderate_topic.handlebars.php
index ab80f28..82c8d4e 100644
--- a/handlebars/compiled/flow_block_topic_moderate_topic.handlebars.php
+++ b/handlebars/compiled/flow_block_topic_moderate_topic.handlebars.php
@@ -73,8 +73,7 @@
'.$sp.' <span class="flow-post-meta-actions">
'.$sp.''.((LCRun3::ifvar($cx, ((isset($in['actions']['reply']) &&
is_array($in['actions'])) ? $in['actions']['reply'] : null))) ? '
<a href="'.htmlentities((string)((isset($in['actions']['reply']['url']) &&
is_array($in['actions']['reply'])) ? $in['actions']['reply']['url'] : null),
ENT_QUOTES, 'UTF-8').'"
'.$sp.'
title="'.htmlentities((string)((isset($in['actions']['reply']['title']) &&
is_array($in['actions']['reply'])) ? $in['actions']['reply']['title'] : null),
ENT_QUOTES, 'UTF-8').'"
-'.$sp.' class="mw-ui-anchor mw-ui-progressive
mw-ui-quiet"
-'.$sp.'
+'.$sp.' class="mw-ui-anchor mw-ui-progressive
mw-ui-quiet flow-reply-link"
'.$sp.' data-flow-eventlog-schema="FlowReplies"
'.$sp.' data-flow-eventlog-action="initiate"
'.$sp.' data-flow-eventlog-entrypoint="reply-post"
diff --git a/handlebars/compiled/flow_block_topiclist.handlebars.php
b/handlebars/compiled/flow_block_topiclist.handlebars.php
index c92fdf8..b7c85b4 100644
--- a/handlebars/compiled/flow_block_topiclist.handlebars.php
+++ b/handlebars/compiled/flow_block_topiclist.handlebars.php
@@ -303,4 +303,4 @@
</div>
';
}
-?>
+?>
\ No newline at end of file
diff --git a/modules/flow-initialize.js b/modules/flow-initialize.js
index 4cda684..aaddb1f 100644
--- a/modules/flow-initialize.js
+++ b/modules/flow-initialize.js
@@ -17,7 +17,7 @@
preloadTopic, preloadContent, preloadFormat,
finishLoading = function () {
$component.addClass( 'flow-component-ready' );
- $( '.flow-ui-load-overlay' ).hide();
+ $( '.flow-ui-load-overlay' ).addClass(
'oo-ui-element-hidden' );
};
// HACK: If there is no component, we are not on a flow
--
To view, visit https://gerrit.wikimedia.org/r/245545
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb3eebd3c227c2855d1b5b40edfb9211d7732480
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
