Yaron Koren has uploaded a new change for review.
https://gerrit.wikimedia.org/r/245597
Change subject: Fixes for handling of SMW "yes" values for checkbox
......................................................................
Fixes for handling of SMW "yes" values for checkbox
Change-Id: I901a6f0a5a5318f9ef58f2ae613a4c2d0d2adcf7
---
M includes/forminputs/SF_CheckboxInput.php
1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms
refs/changes/97/245597/1
diff --git a/includes/forminputs/SF_CheckboxInput.php
b/includes/forminputs/SF_CheckboxInput.php
index d17129f..db9ec82 100644
--- a/includes/forminputs/SF_CheckboxInput.php
+++ b/includes/forminputs/SF_CheckboxInput.php
@@ -46,22 +46,19 @@
} else {
// Default to false - no need to check if it matches
// a 'false' word.
- // We use mb_strtolower() here, and not the more
- // common strtolower(), because only mb_strtolower()
- // works for non-Latin alphabets as well.
- $lowercaseCurValue = mb_strtolower( trim( $cur_value )
);
+ $lowercaseCurValue = strtolower( trim( $cur_value ) );
$possibleYesMessages = array(
- mb_strtolower( wfMessage( 'htmlform-yes'
)->inContentLanguage()->text() ),
+ strtolower( wfMessage( 'htmlform-yes'
)->inContentLanguage()->text() ),
// Add in '1', and some hardcoded English.
'1', 'yes', 'true'
);
// Add values from Semantic MediaWiki, if it's
installed.
if ( wfMessage( 'smw_true_words' )->exists() ) {
- $smwTrueWords = explode( ',', wfMessage(
'smw_true_words' )->inContentLanguage()->text(), true );
+ $smwTrueWords = explode( ',', wfMessage(
'smw_true_words' )->inContentLanguage()->text() );
foreach ( $smwTrueWords as $smwTrueWord ) {
- $possibleYesMessages = mb_strtolower(
trim( $smwTrueWord ) );
+ $possibleYesMessages[] = strtolower(
trim( $smwTrueWord ) );
}
}
$isChecked = in_array( $lowercaseCurValue,
$possibleYesMessages );
--
To view, visit https://gerrit.wikimedia.org/r/245597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I901a6f0a5a5318f9ef58f2ae613a4c2d0d2adcf7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
