jenkins-bot has submitted this change and it was merged. Change subject: Changed LoginForm::addNewaccountInternal() to return Status. ......................................................................
Changed LoginForm::addNewaccountInternal() to return Status. Rather than calling mainLoginForm() and returning false, the addNewaccountInternal() function now returns a Status on failure. mainLoginForm() is then called in addNewAccount() and addNewAccountMailPassword() instead. This allows for processing of the account creation form without submitting anything to $wgOut. Change-Id: I402c6bebcfe276233cc1f9e16efbe55a034b2181 --- M includes/AutoLoader.php M includes/Message.php M includes/specials/SpecialUserlogin.php 3 files changed, 96 insertions(+), 83 deletions(-) Approvals: CSteipp: Looks good to me, but someone else must approve Tychay: Verified; Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/17952 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I402c6bebcfe276233cc1f9e16efbe55a034b2181 Gerrit-PatchSet: 29 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Parent5446 <[email protected]> Gerrit-Reviewer: Akshay <[email protected]> Gerrit-Reviewer: Brion VIBBER <[email protected]> Gerrit-Reviewer: CSteipp <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Dan Collins <[email protected]> Gerrit-Reviewer: IAlex <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Parent5446 <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: Spage <[email protected]> Gerrit-Reviewer: Tim Starling <[email protected]> Gerrit-Reviewer: Tychay <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
