Subramanya Sastry has submitted this change and it was merged. Change subject: Fix regression introduced by 6710479b6748e15053c8e1cacb64a4471b1ce1df ......................................................................
Fix regression introduced by 6710479b6748e15053c8e1cacb64a4471b1ce1df Newline-only template parameters were no longer matched after protecting the sol production in block elements against inline breaks. This caused some template transclusions to be parsed as plain text, which was then nowiki-escaped in the serializer causing rt failures in testing. That code was not deployed, so hooray for rt testing ;) With this patch, some of the tests added in https://gerrit.wikimedia.org/r/38750 are now passing (+5 green). One of the two tests does not pass as the PHP parser emits <p><br/></p> for a simple {{echo|\n}}, which looks more like a bug than a feature. Change-Id: I9aa173ed8e90695dbd3ed94505f279b237853f77 --- M js/lib/pegTokenizer.pegjs.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Subramanya Sastry: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/38752 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aa173ed8e90695dbd3ed94505f279b237853f77 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke <[email protected]> Gerrit-Reviewer: Subramanya Sastry <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
