Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/245855

Change subject: Mock ChangesList instead of constructing.
......................................................................

Mock ChangesList instead of constructing.

No need to actually make one of these.
Also this class may be going abstract in core.

Change-Id: Ice8e443657e19699444653463c0814132a18989c
---
M repo/tests/phpunit/includes/Hooks/LabelPrefetchHookHandlersTest.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/55/245855/2

diff --git 
a/repo/tests/phpunit/includes/Hooks/LabelPrefetchHookHandlersTest.php 
b/repo/tests/phpunit/includes/Hooks/LabelPrefetchHookHandlersTest.php
index 1486476..2cd7d93 100644
--- a/repo/tests/phpunit/includes/Hooks/LabelPrefetchHookHandlersTest.php
+++ b/repo/tests/phpunit/includes/Hooks/LabelPrefetchHookHandlersTest.php
@@ -133,7 +133,10 @@
                $context->setRequest( new FauxRequest() );
                $context->setTitle( new Title( NS_SPECIAL, 'Watchlist' ) );
 
-               $changesList = new ChangesList( $context );
+               /** @var ChangesList $changesList */
+               $changesList = $this->getMockBuilder( 'ChangesList' )
+               ->disableOriginalConstructor()
+               ->getMock();
 
                $linkBeginHookHandler->doChangesListInitRows(
                        $changesList,

-- 
To view, visit https://gerrit.wikimedia.org/r/245855
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice8e443657e19699444653463c0814132a18989c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to