Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/245954
Change subject: Remove not used getUser
......................................................................
Remove not used getUser
Change-Id: Idab78ea098c766c8464c0512b418848568b9cc7f
---
M client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
M lib/includes/changes/ChangeRow.php
M lib/tests/phpunit/changes/ChangeRowTest.php
3 files changed, 0 insertions(+), 23 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/54/245954/1
diff --git a/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
b/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
index 426f657..21845c5 100644
--- a/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
+++ b/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
@@ -195,7 +195,6 @@
$this->assertEquals( $expected->getObjectId(),
$actual->getObjectId(), $message . 'ObjectId' );
$this->assertEquals( $expected->getTime(), $actual->getTime(),
$message . 'Time' );
$this->assertEquals( $expected->getType(), $actual->getType(),
$message . 'Type' );
- $this->assertEquals( $expected->getUser(), $actual->getUser(),
$message . 'User' );
if ( $expected instanceof EntityChange && $actual instanceof
EntityChange ) {
$this->assertEquals( $expected->getAction(),
$actual->getAction(), $message . 'Action' );
diff --git a/lib/includes/changes/ChangeRow.php
b/lib/includes/changes/ChangeRow.php
index 583c42a..ad2058b 100644
--- a/lib/includes/changes/ChangeRow.php
+++ b/lib/includes/changes/ChangeRow.php
@@ -33,21 +33,6 @@
private $fields = array( 'id' => null );
/**
- * @see Change::getUser
- *
- * @since 0.1
- *
- * @return User
- */
- public function getUser() {
- if ( $this->user === false ) {
- $this->user = User::newFromId( $this->getField(
'user_id' ) );
- }
-
- return $this->user;
- }
-
- /**
* @see Change::getAge
*
* @since 0.1
diff --git a/lib/tests/phpunit/changes/ChangeRowTest.php
b/lib/tests/phpunit/changes/ChangeRowTest.php
index 45b17ff..3832e32 100644
--- a/lib/tests/phpunit/changes/ChangeRowTest.php
+++ b/lib/tests/phpunit/changes/ChangeRowTest.php
@@ -37,13 +37,6 @@
/**
* @dataProvider changeProvider
*/
- public function testGetUser( ChangeRow $changeRow ) {
- $this->assertInstanceOf( '\User', $changeRow->getUser() );
- }
-
- /**
- * @dataProvider changeProvider
- */
public function testGetAge( ChangeRow $changeRow ) {
// Don't assert on equalness because all previous code takes
time!
$this->assertTrue(
--
To view, visit https://gerrit.wikimedia.org/r/245954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idab78ea098c766c8464c0512b418848568b9cc7f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
