jenkins-bot has submitted this change and it was merged.
Change subject: Minor cleanup
......................................................................
Minor cleanup
Change-Id: Iaa2e3d54f89d85b6fb5ea2981de2af6e5ec3724e
---
M PaymentProviders/Amazon/Actions/AssociateRefundParent.php
M PaymentProviders/Amazon/Actions/CloseOrderReference.php
M PaymentProviders/Amazon/AmazonApi.php
M PaymentProviders/Amazon/Audit/SettlementReport.php
4 files changed, 3 insertions(+), 8 deletions(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/PaymentProviders/Amazon/Actions/AssociateRefundParent.php
b/PaymentProviders/Amazon/Actions/AssociateRefundParent.php
index 0d8beb3..c44f371 100644
--- a/PaymentProviders/Amazon/Actions/AssociateRefundParent.php
+++ b/PaymentProviders/Amazon/Actions/AssociateRefundParent.php
@@ -13,7 +13,7 @@
public function execute( ListenerMessage $msg ) {
// Bail out if not a refund
- if ( get_class( $msg ) !== self::MESSAGE_CLASS ) {
+ if ( !( $msg instanceof $this->MESSAGE_CLASS ) ) {
return true;
}
$refundId = $msg->gateway_txn_id;
diff --git a/PaymentProviders/Amazon/Actions/CloseOrderReference.php
b/PaymentProviders/Amazon/Actions/CloseOrderReference.php
index 1eecdb0..d9bebf9 100644
--- a/PaymentProviders/Amazon/Actions/CloseOrderReference.php
+++ b/PaymentProviders/Amazon/Actions/CloseOrderReference.php
@@ -10,7 +10,7 @@
public function execute( ListenerMessage $msg ) {
// only close after successful capture
- if ( get_class( $msg ) !== self::MESSAGE_CLASS ) {
+ if ( !( $msg instanceof $this->MESSAGE_CLASS ) ) {
return true;
}
diff --git a/PaymentProviders/Amazon/AmazonApi.php
b/PaymentProviders/Amazon/AmazonApi.php
index cffecb3..10bbc38 100644
--- a/PaymentProviders/Amazon/AmazonApi.php
+++ b/PaymentProviders/Amazon/AmazonApi.php
@@ -37,11 +37,7 @@
"No authorizations found for order reference
$orderReferenceId!"
);
}
- if ( is_array( $details['IdList']['member'] ) ) {
- $authorizationIds = $details['IdList']['member'];
- } else {
- $authorizationIds = array( $details['IdList']['member']
);
- }
+ $authorizationIds = ( array ) $details['IdList']['member'];
// Check the status of each authorization against the order
reference
foreach ( $authorizationIds as $id ) {
$authResult = $client->getAuthorizationDetails( array(
diff --git a/PaymentProviders/Amazon/Audit/SettlementReport.php
b/PaymentProviders/Amazon/Audit/SettlementReport.php
index 0867801..9b8f524 100644
--- a/PaymentProviders/Amazon/Audit/SettlementReport.php
+++ b/PaymentProviders/Amazon/Audit/SettlementReport.php
@@ -34,7 +34,6 @@
}
/**
- *
* @param HeadedCsvReader $csv
* @throws OutOfBoundsException
*/
--
To view, visit https://gerrit.wikimedia.org/r/244705
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa2e3d54f89d85b6fb5ea2981de2af6e5ec3724e
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
