jenkins-bot has submitted this change and it was merged.
Change subject: Don't check instanceof IORMRow in ChangeHandler
......................................................................
Don't check instanceof IORMRow in ChangeHandler
Change-Id: I19e482f255e7280caa507c4cab6be8a706042c8a
---
M client/includes/Changes/ChangeHandler.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
JanZerebecki: Looks good to me, approved
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/includes/Changes/ChangeHandler.php
b/client/includes/Changes/ChangeHandler.php
index 4137596..83d91fb 100644
--- a/client/includes/Changes/ChangeHandler.php
+++ b/client/includes/Changes/ChangeHandler.php
@@ -5,7 +5,6 @@
use Exception;
use Hooks;
use InvalidArgumentException;
-use IORMRow;
use Language;
use Message;
use MWException;
@@ -323,8 +322,8 @@
* @return string
*/
private function getChangeIdForLog( Change $change ) {
- if ( $change instanceof IORMRow ) {
- //@todo: add getFields() to the interface, or provide
getters!
+ if ( $change instanceof EntityChange ) {
+ //@todo: add getFields() to the Change interface, or
provide getters!
$fields = $change->getFields();
if ( isset( $fields['info']['change-ids'] ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/245966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19e482f255e7280caa507c4cab6be8a706042c8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
