Kaldari has submitted this change and it was merged. Change subject: Make UW more resilient againt misconfigurations ......................................................................
Make UW more resilient againt misconfigurations If you expect a non-empty string, then test for that! Try running UW with e.g. $wgUploadWizardConfig['feedbackPage'] = null: you'll get an empty Special:UplaodWizard page because mw.Title() raises an exception. Happend on my first attempt to install UW on my local test wiki, and took me some debugging with Firebug to find. That can easily be avoided. Change-Id: I0f3ff484870b1ba8126ccf1d1d77bc0a874f607b --- M resources/mw.UploadWizard.js M resources/mw.UploadWizardDetails.js 2 files changed, 12 insertions(+), 13 deletions(-) Approvals: Kaldari: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36394 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f3ff484870b1ba8126ccf1d1d77bc0a874f607b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Lupo <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: MarkTraceur <[email protected]> Gerrit-Reviewer: Matthias Mullie <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
