Andrew Bogott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/246081
Change subject: service_unit: Add a service_running arg
......................................................................
service_unit: Add a service_running arg
I hate this, but it seems necessary. Previously with
ensure => absent, we removed the init script and then
tried to set service => stopped using the now-missing
manifest.
Bug: T115347
Change-Id: I9f343413bf7de7e9bd8b2579f0390b15f0d7f60a
---
M modules/base/manifests/service_unit.pp
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/81/246081/1
diff --git a/modules/base/manifests/service_unit.pp
b/modules/base/manifests/service_unit.pp
index ce22c99..3cb68be 100644
--- a/modules/base/manifests/service_unit.pp
+++ b/modules/base/manifests/service_unit.pp
@@ -40,6 +40,12 @@
#[*declare_service*]
# Boolean - tells puppet if a service {} stanza is required or not
#
+#[*service_running*]
+# Boolean, determines whether or not the defined service is running.
+# Note that ensure => absent and running -> false will cause an error
+# since we can't stop a nonexistent service.
+#
+#
#[*service_params*]
# An hash of parameters that we want to apply to the service resource
#
@@ -67,6 +73,7 @@
$refresh = true,
$template_name = $name,
$declare_service = true,
+ $service_running = true,
$service_params = {},
) {
@@ -135,7 +142,7 @@
if $declare_service {
$base_params = {
- ensure => ensure_service($ensure),
+ ensure => $service_running,
provider => $::initsystem,
}
$params = merge($base_params, $service_params)
--
To view, visit https://gerrit.wikimedia.org/r/246081
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f343413bf7de7e9bd8b2579f0390b15f0d7f60a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
