jenkins-bot has submitted this change and it was merged.
Change subject: Revert "mediawiki.widgets: Add temporary workaround for
upstream oojs-ui bug"
......................................................................
Revert "mediawiki.widgets: Add temporary workaround for upstream oojs-ui bug"
No longer needed.
This reverts commit ca751872aac2be673d88fe9067472808c6500bb5.
Change-Id: Iefa3386d448826a220fe0e861fe38fc9f1809d4d
---
M resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
index c37c723..0e2546f 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
@@ -63,11 +63,7 @@
* @param {OO.ui.OptionWidget} item Chosen item
*/
mw.widgets.TitleSearchWidget.prototype.onTitleSearchResultsChoose =
function ( item ) {
- // TOOD: Pressing enter can incorrectly trigger 'choose' with
null.
- // Remove this check when oojs-ui 0.12.10 lands.
- if ( item ) {
- this.getQuery().setValue( item.getData() );
- }
+ this.getQuery().setValue( item.getData() );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/246062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefa3386d448826a220fe0e861fe38fc9f1809d4d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
