Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/246158

Change subject: Move comment in backup_PageTest.php
......................................................................

Move comment in backup_PageTest.php

Move the comment at the begin of the function out of it to a doc
comment.

Change-Id: I6febf51a74de88204d54b1e3251df187197c1819
---
M tests/phpunit/maintenance/backup_PageTest.php
1 file changed, 11 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/58/246158/1

diff --git a/tests/phpunit/maintenance/backup_PageTest.php 
b/tests/phpunit/maintenance/backup_PageTest.php
index 0cb0cdb..8b6221b 100644
--- a/tests/phpunit/maintenance/backup_PageTest.php
+++ b/tests/phpunit/maintenance/backup_PageTest.php
@@ -288,17 +288,18 @@
                $this->assertDumpEnd();
        }
 
+       /**
+        * xmldumps-backup typically performs a single dump that that writes
+        * out three files
+        * - gzipped stubs of everything (meta-history)
+        * - gzipped stubs of latest revisions of all pages (meta-current)
+        * - gzipped stubs of latest revisions of all pages of namespage 0
+        *   (articles)
+        *
+        * We reproduce such a setup with our mini fixture, although we omit
+        * chunks, and all the other gimmicks of xmldumps-backup.
+        */
        function testXmlDumpsBackupUseCase() {
-               // xmldumps-backup typically performs a single dump that that 
writes
-               // out three files
-               // * gzipped stubs of everything (meta-history)
-               // * gzipped stubs of latest revisions of all pages 
(meta-current)
-               // * gzipped stubs of latest revisions of all pages of 
namespage 0
-               //   (articles)
-               //
-               // We reproduce such a setup with our mini fixture, although we 
omit
-               // chunks, and all the other gimmicks of xmldumps-backup.
-               //
                $this->checkHasGzip();
 
                $fnameMetaHistory = $this->getNewTempFile();

-- 
To view, visit https://gerrit.wikimedia.org/r/246158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6febf51a74de88204d54b1e3251df187197c1819
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to