jenkins-bot has submitted this change and it was merged.
Change subject: Move the "shit" out
......................................................................
Move the "shit" out
There is no need for such words
Change-Id: I0294c0e2381b96fd4377d7edcdf4d7e7fc0d06d3
---
M includes/Title.php
M includes/specials/SpecialUndelete.php
M maintenance/backupTextPass.inc
3 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Parent5446: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Title.php b/includes/Title.php
index 8e5fae9..7fb2b06 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -1008,10 +1008,8 @@
*/
public function getNsText() {
if ( $this->isExternal() ) {
- // This probably shouldn't even happen. ohh man, oh
yuck.
- // But for interwiki transclusion it sometimes does.
- // Shit. Shit shit shit.
- //
+ // This probably shouldn't even happen,
+ // but for interwiki transclusion it sometimes does.
// Use the canonical namespaces if possible to try to
// resolve a foreign namespace.
if ( MWNamespace::exists( $this->mNamespace ) ) {
diff --git a/includes/specials/SpecialUndelete.php
b/includes/specials/SpecialUndelete.php
index 00ee327..447c3ef 100644
--- a/includes/specials/SpecialUndelete.php
+++ b/includes/specials/SpecialUndelete.php
@@ -587,7 +587,7 @@
$restored = 0;
foreach ( $result as $row ) {
- // Check for key dupes due to shitty archive integrity.
+ // Check for key dupes due to needed archive integrity.
if ( $row->ar_rev_id ) {
$exists = $dbw->selectField( 'revision', '1',
array( 'rev_id' => $row->ar_rev_id ),
__METHOD__ );
diff --git a/maintenance/backupTextPass.inc b/maintenance/backupTextPass.inc
index 11a0590..0ed584c 100644
--- a/maintenance/backupTextPass.inc
+++ b/maintenance/backupTextPass.inc
@@ -699,7 +699,6 @@
$this->progress( "Spawning database subprocess: $cmd" );
$this->spawnProc = proc_open( $cmd, $spec, $pipes );
if ( !$this->spawnProc ) {
- // shit
$this->progress( "Subprocess spawn failed." );
return false;
--
To view, visit https://gerrit.wikimedia.org/r/246159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0294c0e2381b96fd4377d7edcdf4d7e7fc0d06d3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
