Mvolz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/246163
Change subject: [WIP] Fix lack of response when export fails
......................................................................
[WIP] Fix lack of response when export fails
Current patch fixes issue, but doesn't solve
underlying issue which is that fillBody should
have filled the error when called in CitoidService.
Bug: T115271
Change-Id: I09e40682521f4d99775c4669238117b813985521
---
M lib/Exporter.js
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/citoid
refs/changes/63/246163/1
diff --git a/lib/Exporter.js b/lib/Exporter.js
index ff95b2a..7c46446 100644
--- a/lib/Exporter.js
+++ b/lib/Exporter.js
@@ -99,6 +99,7 @@
cr.logger.log('trace/zotero', message);
cr.response.error = error;
cr.response.responseCode = 404; // 404 error if cannot
translate into alternate format
+ cr.response.body = cr.response.error; // TODO: Shouldn't be
necessary due tofill body being called
return cr;
}
--
To view, visit https://gerrit.wikimedia.org/r/246163
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09e40682521f4d99775c4669238117b813985521
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid
Gerrit-Branch: master
Gerrit-Owner: Mvolz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
