jenkins-bot has submitted this change and it was merged.
Change subject: ReCaptchaNoCaptcha: Fix undefined function call to
logStatusError()
......................................................................
ReCaptchaNoCaptcha: Fix undefined function call to logStatusError()
It seems that logCheckError() works fine for logging errors, so
I changed any logStatusError() calls into logCheckError() ones.
Change-Id: I4dc6fe0c7ddc10f388f43caa928fefce1a0dac3a
---
M ReCaptchaNoCaptcha/ReCaptchaNoCaptcha.class.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
Objections:
Southparkfan: There's a problem with this change, please improve
diff --git a/ReCaptchaNoCaptcha/ReCaptchaNoCaptcha.class.php
b/ReCaptchaNoCaptcha/ReCaptchaNoCaptcha.class.php
index 4140b24..bf92f70 100644
--- a/ReCaptchaNoCaptcha/ReCaptchaNoCaptcha.class.php
+++ b/ReCaptchaNoCaptcha/ReCaptchaNoCaptcha.class.php
@@ -85,13 +85,13 @@
$status = $request->execute();
if ( !$status->isOK() ) {
$this->error = 'http';
- $this->logStatusError( $status );
+ $this->logCheckError( $status );
return false;
}
$response = FormatJson::decode( $request->getContent(), true );
if ( !$response ) {
$this->error = 'json';
- $this->logStatusError( $this->error );
+ $this->logCheckError( $this->error );
return false;
}
if ( isset( $response['error-codes'] ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/246209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4dc6fe0c7ddc10f388f43caa928fefce1a0dac3a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ConfirmEdit
Gerrit-Branch: master
Gerrit-Owner: Southparkfan <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Southparkfan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
