jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused code from CirrusSearch File
......................................................................
Remove unused code from CirrusSearch File
Few issues PHPStorm was pointing out
Change-Id: Ifb9298a2f3a2cbdd3a34363c13e40e898455dfa2
---
M includes/ElasticsearchIntermediary.php
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Cindy-the-browser-test-bot: Looks good to me, but someone else must approve
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/ElasticsearchIntermediary.php
b/includes/ElasticsearchIntermediary.php
index 018ed5b..c0af174 100644
--- a/includes/ElasticsearchIntermediary.php
+++ b/includes/ElasticsearchIntermediary.php
@@ -93,7 +93,6 @@
$this->user = $user;
$this->slowMillis = round( 1000 * $slowSeconds );
$this->ut = UserTesting::getInstance();
- $config = ConfigFactory::getDefaultInstance()->makeConfig(
'CirrusSearch' );
}
/**
@@ -161,7 +160,6 @@
FormatJson::encode( $parameters ),
);
- $tests = array();
$logger = LoggerFactory::getInstance( 'CirrusSearchUserTesting'
);
foreach ( $ut->getActiveTestNames() as $test ) {
$bucket = $ut->getBucket( $test );
@@ -302,7 +300,7 @@
/**
* Log the completion of a request to Elasticsearch.
- * @return int number of milliseconds it took to complete the request
+ * @return int|null number of milliseconds it took to complete the
request
*/
private function finishRequest() {
global $wgCirrusSearchLogElasticRequests;
--
To view, visit https://gerrit.wikimedia.org/r/242268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb9298a2f3a2cbdd3a34363c13e40e898455dfa2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Cindy-the-browser-test-bot <[email protected]>
Gerrit-Reviewer: DCausse <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
