Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/246403
Change subject: Browser tests: Update link inspector tests
......................................................................
Browser tests: Update link inspector tests
Change-Id: I5e902b4ab3215450a4374fb7327159d3edfc5ef2
---
M modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
2 files changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/03/246403/1
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
index 334fdce..e42902c 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
@@ -14,7 +14,6 @@
on(VisualEditorPage) do |page|
page.link_textfield_element.when_present
page.link_textfield_element.send_keys(link_content)
- page.link_overlay_external_link_element.when_present
end
end
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 4ad65d5..1c82128 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -99,9 +99,8 @@
div(:language_notification, class: 'tipsy-inner')
div(:left_navigation, id: 'left-navigation')
div(:link_list, class: 'oo-ui-windowManager-floating')
- div(:link_overlay_does_not_exist, text: /New page/)
- div(:link_overlay_external_link, text: /External link.+New page/m)
- div(:link_overlay_wiki_page, text: /Matching page/)
+ span(:link_overlay_does_not_exist, text: /page does not exist yet/)
+ div(:link_overlay_wiki_page, class: 'mw-widget-titleOptionWidget')
text_field(:link_textfield, index: 0)
span(:links_done, text: 'Done')
unordered_list(:media_caption, class: 've-ui-contextSelectWidget')
--
To view, visit https://gerrit.wikimedia.org/r/246403
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e902b4ab3215450a4374fb7327159d3edfc5ef2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
