Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/246452
Change subject: Update icon for use in notifications.
......................................................................
Update icon for use in notifications.
The icon is now a white square with a transparent W cut out of it, which
is compliant with the visual requirements of notifications under Lollipop
and higher.
Bug: T114890
Change-Id: I191e4690e818c79c16b4c34269ba5048ccc400ff
---
M app/src/main/java/org/wikipedia/alphaupdater/AlphaUpdateChecker.java
M app/src/main/java/org/wikipedia/page/gallery/SavedImageNotificationHelper.java
A app/src/main/res/drawable-hdpi/ic_notification.png
A app/src/main/res/drawable-mdpi/ic_notification.png
A app/src/main/res/drawable-xhdpi/ic_notification.png
A app/src/main/res/drawable-xxhdpi/ic_notification.png
A icon-svgs/24/ic_notification.noflip.svg
7 files changed, 85 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/52/246452/1
diff --git
a/app/src/main/java/org/wikipedia/alphaupdater/AlphaUpdateChecker.java
b/app/src/main/java/org/wikipedia/alphaupdater/AlphaUpdateChecker.java
index 4c2cf08..7456ef2 100644
--- a/app/src/main/java/org/wikipedia/alphaupdater/AlphaUpdateChecker.java
+++ b/app/src/main/java/org/wikipedia/alphaupdater/AlphaUpdateChecker.java
@@ -64,7 +64,7 @@
Intent intent = new Intent(Intent.ACTION_VIEW,
Uri.parse("https://android-builds.wmflabs.org/runs/latest/wikipedia.apk";));
PendingIntent pintent = PendingIntent.getActivity(context, 0, intent,
0);
- Notification notification = new
NotificationCompat.Builder(context).setSmallIcon(R.drawable.launcher)
+ Notification notification = new
NotificationCompat.Builder(context).setSmallIcon(R.drawable.ic_notification)
.setContentTitle(context.getString(R.string.alpha_update_notification_title))
.setContentText(context.getString(R.string.alpha_update_notification_text))
.setContentIntent(pintent)
diff --git
a/app/src/main/java/org/wikipedia/page/gallery/SavedImageNotificationHelper.java
b/app/src/main/java/org/wikipedia/page/gallery/SavedImageNotificationHelper.java
index 359f9a2..bed032d 100644
---
a/app/src/main/java/org/wikipedia/page/gallery/SavedImageNotificationHelper.java
+++
b/app/src/main/java/org/wikipedia/page/gallery/SavedImageNotificationHelper.java
@@ -33,7 +33,7 @@
NotificationCompat.Action savedImageShareAction =
buildSavedImageShareAction(savedImageSharePendingIntent);
return new NotificationCompat.Builder(WikipediaApp.getInstance())
- .setSmallIcon(R.drawable.launcher)
+ .setSmallIcon(R.drawable.ic_notification)
.setContentTitle(getString(R.string.gallery_image_saved_notification_title))
.setContentText(getString(R.string.gallery_image_saved_notification_text))
.setContentIntent(viewInDefaultViewerAppPendingIntent)
diff --git a/app/src/main/res/drawable-hdpi/ic_notification.png
b/app/src/main/res/drawable-hdpi/ic_notification.png
new file mode 100644
index 0000000..6f98310
--- /dev/null
+++ b/app/src/main/res/drawable-hdpi/ic_notification.png
Binary files differ
diff --git a/app/src/main/res/drawable-mdpi/ic_notification.png
b/app/src/main/res/drawable-mdpi/ic_notification.png
new file mode 100644
index 0000000..22766b3
--- /dev/null
+++ b/app/src/main/res/drawable-mdpi/ic_notification.png
Binary files differ
diff --git a/app/src/main/res/drawable-xhdpi/ic_notification.png
b/app/src/main/res/drawable-xhdpi/ic_notification.png
new file mode 100644
index 0000000..6671e39
--- /dev/null
+++ b/app/src/main/res/drawable-xhdpi/ic_notification.png
Binary files differ
diff --git a/app/src/main/res/drawable-xxhdpi/ic_notification.png
b/app/src/main/res/drawable-xxhdpi/ic_notification.png
new file mode 100644
index 0000000..261550c
--- /dev/null
+++ b/app/src/main/res/drawable-xxhdpi/ic_notification.png
Binary files differ
diff --git a/icon-svgs/24/ic_notification.noflip.svg
b/icon-svgs/24/ic_notification.noflip.svg
new file mode 100644
index 0000000..04d3fb9
--- /dev/null
+++ b/icon-svgs/24/ic_notification.noflip.svg
@@ -0,0 +1,83 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<svg
+ xmlns:sketch="http://www.bohemiancoding.com/sketch/ns";
+ xmlns:dc="http://purl.org/dc/elements/1.1/";
+ xmlns:cc="http://creativecommons.org/ns#";
+ xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#";
+ xmlns:svg="http://www.w3.org/2000/svg";
+ xmlns="http://www.w3.org/2000/svg";
+ xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd";
+ xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape";
+ width="48"
+ height="48"
+ viewBox="0 0 48 48"
+ version="1.1"
+ id="svg2"
+ inkscape:version="0.91 r13725"
+ sodipodi:docname="notification1.svg"
+ inkscape:export-filename="E:\Desktop\notification1.png"
+ inkscape:export-xdpi="298.04144"
+ inkscape:export-ydpi="298.04144">
+ <metadata
+ id="metadata17">
+ <rdf:RDF>
+ <cc:Work
+ rdf:about="">
+ <dc:format>image/svg+xml</dc:format>
+ <dc:type
+ rdf:resource="http://purl.org/dc/dcmitype/StillImage"; />
+ <dc:title>Imported Layers</dc:title>
+ </cc:Work>
+ </rdf:RDF>
+ </metadata>
+ <sodipodi:namedview
+ pagecolor="#ffffff"
+ bordercolor="#666666"
+ borderopacity="1"
+ objecttolerance="10"
+ gridtolerance="10"
+ guidetolerance="10"
+ inkscape:pageopacity="0"
+ inkscape:pageshadow="2"
+ inkscape:window-width="640"
+ inkscape:window-height="480"
+ id="namedview15"
+ showgrid="false"
+ inkscape:zoom="13.013889"
+ inkscape:cx="12.834869"
+ inkscape:cy="24.916575"
+ inkscape:current-layer="svg2" />
+ <!-- Generator: Sketch 3.3.3 (12072) - http://www.bohemiancoding.com/sketch
-->
+ <title
+ id="title4">Imported Layers</title>
+ <desc
+ id="desc6">Created with Sketch.</desc>
+ <defs
+ id="defs8" />
+ <path
+ style="fill:#ffffff"
+ d="M 8.0175781 4.5839844 C 6.2080847 4.5839844 4.75 6.042069 4.75
7.8515625 L 4.75 39.96875 C 4.75 41.778243 6.2080847 43.236328 8.0175781
43.236328 L 40.134766 43.236328 C 41.944259 43.236328 43.402344 41.778243
43.402344 39.96875 L 43.402344 7.8515625 C 43.402344 6.042069 41.944259
4.5839844 40.134766 4.5839844 L 8.0175781 4.5839844 z M 25.691406 16.394531 C
26.077133 16.394531 26.551462 16.417364 27.115234 16.464844 C 27.655283
16.512248 28.099168 16.537109 28.443359 16.537109 C 28.692576 16.537109
29.060394 16.512153 29.541016 16.476562 C 30.152236 16.423176 30.668675
16.394531 31.078125 16.394531 C 31.173098 16.394531 31.220703 16.488011
31.220703 16.683594 C 31.220703 16.938544 31.133124 17.070312 30.955078
17.070312 C 30.326046 17.135504 29.821273 17.307241 29.435547 17.591797 C
29.049821 17.876353 28.57359 18.509866 28.003906 19.511719 L 25.683594
23.798828 L 28.830078 30.195312 L 33.470703 19.412109 C 33.630936 19.020865
33.712891 18.652222 33.712891 18.326172 C 33.712891 17.537697 33.173768
17.117713 32.09375 17.070312 C 31.992865 17.070312 31.945312 16.957689
31.945312 16.732422 C 31.945312 16.507155 32.01573 16.394531 32.164062
16.394531 C 32.555701 16.394531 33.026436 16.417364 33.566406 16.464844 C
34.064919 16.512248 34.486018 16.537109 34.824219 16.537109 C 35.18031
16.537109 35.589795 16.512323 36.058594 16.464844 C 36.545205 16.417439
36.977555 16.394531 37.363281 16.394531 C 37.475752 16.394374 37.529297
16.488011 37.529297 16.683594 L 37.439453 16.951172 C 37.380107 17.028256
37.315442 17.070312 37.238281 17.070312 C 36.644874 17.129605 36.153122
17.318402 35.779297 17.644531 C 35.399482 17.970582 35.007055 18.592901
34.603516 19.505859 L 28.4375 33.378906 C 28.395965 33.509295 28.283567
33.574219 28.099609 33.574219 C 27.951278 33.574219 27.844791 33.509377
27.761719 33.378906 L 24.306641 26.164062 L 20.332031 33.384766 C 20.248959
33.515155 20.134609 33.580078 19.992188 33.580078 C 19.814142 33.580078
19.695936 33.515235 19.642578 33.384766 L 13.589844 19.511719 C 13.210029
18.652066 12.811898 18.046846 12.390625 17.708984 C 11.975185 17.365139
11.388355 17.159161 10.640625 17.076172 C 10.575365 17.076172 10.516379
17.039802 10.457031 16.974609 C 10.397683 16.909415 10.373047 16.827129
10.373047 16.744141 C 10.373047 16.518873 10.439714 16.40625 10.570312 16.40625
C 11.110362 16.40625 11.67227 16.429091 12.259766 16.476562 C 12.805726
16.523959 13.322113 16.548828 13.802734 16.548828 C 14.295257 16.548828
14.878312 16.524042 15.542969 16.476562 C 16.24325 16.429166 16.86628 16.40625
17.40625 16.40625 C 17.53677 16.40625 17.601563 16.518873 17.601562 16.744141 C
17.601562 16.969407 17.559583 17.082031 17.482422 17.082031 C 16.942373
17.123529 16.515597 17.259062 16.207031 17.490234 C 15.898466 17.721407
15.744141 18.030722 15.744141 18.410156 C 15.744141 18.605818 15.808854
18.842273 15.939453 19.132812 L 20.943359 30.419922 L 23.785156 25.060547 L
21.138672 19.517578 C 20.663883 18.527536 20.271456 17.888072 19.962891
17.603516 C 19.654325 17.318959 19.191429 17.141367 18.574219 17.076172 C
18.514873 17.076172 18.46151 17.039802 18.414062 16.974609 C 18.360623
16.909418 18.337891 16.827129 18.337891 16.744141 C 18.337891 16.518873
18.39107 16.40625 18.509766 16.40625 C 19.049814 16.40625 19.543076 16.429083
19.994141 16.476562 C 20.427315 16.523959 20.890211 16.548828 21.382812
16.548828 C 21.863512 16.548828 22.372061 16.524042 22.912109 16.476562 C
23.469971 16.429166 24.016671 16.40625 24.556641 16.40625 C 24.68716 16.40625
24.751953 16.518873 24.751953 16.744141 C 24.751953 16.969408 24.717842
17.082031 24.634766 17.082031 C 23.554669 17.153213 23.013672 17.460493
23.013672 18 C 23.013672 18.243062 23.139376 18.617175 23.388672 19.121094 L
25.138672 22.671875 L 26.876953 19.423828 C 27.120259 18.96731 27.238281
18.575959 27.238281 18.261719 C 27.238281 17.520644 26.699159 17.129556
25.619141 17.076172 C 25.518256 17.076172 25.470703 16.963548 25.470703
16.738281 C 25.470703 16.655293 25.495444 16.576959 25.542969 16.505859 C
25.590417 16.434681 25.643959 16.394531 25.691406 16.394531 z "
+ id="rect3356" />
+ <g
+ id="Page-1"
+ sketch:type="MSPage"
+ style="fill:#333333;fill-rule:evenodd;stroke:none;stroke-width:1"
+ transform="matrix(0.75532204,0,0,0.75532204,10.373532,16.39381)">
+ <g
+ id="Logged-in"
+ sketch:type="MSArtboardGroup"
+ transform="translate(-31,-65)"
+ style="fill:#333333">
+ <g
+ id="drawer-bg-+-account-switcher"
+ sketch:type="MSLayerGroup"
+ transform="translate(1,0)"
+ style="fill:#333333">
+ <g
+ id="account-switcher"
+ sketch:type="MSShapeGroup"
+ style="fill:#333333" />
+ </g>
+ </g>
+ </g>
+</svg>
--
To view, visit https://gerrit.wikimedia.org/r/246452
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I191e4690e818c79c16b4c34269ba5048ccc400ff
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
