jenkins-bot has submitted this change and it was merged.
Change subject: Fix bad @covers tags in tests
......................................................................
Fix bad @covers tags in tests
Found with this regex:
(?s)\A(?=.*@covers\W*(\b\S+\b))(?!.*\nuse \1;)
It searces for the class name in a @covers tag that does not have
a corresponding use clause.
Change-Id: Ib828a3e45dc809351f218cb6b3c28b330b018c41
---
M client/tests/phpunit/includes/Hooks/MovePageNoticeTest.php
M client/tests/phpunit/includes/Hooks/ParserLimitHookHandlersTest.php
M client/tests/phpunit/includes/Usage/UsageTrackingSnakFormatterTest.php
M lib/tests/phpunit/formatters/ErrorHandlingSnakFormatterTest.php
M lib/tests/phpunit/sites/SiteMatrixParserTest.php
M lib/tests/phpunit/sites/SitesBuilderTest.php
M repo/tests/phpunit/includes/LinkedData/EntityDataFormatProviderTest.php
M
repo/tests/phpunit/includes/Notifications/JobQueueChangeNotificationSenderTest.php
M repo/tests/phpunit/includes/StatementRankSerializerTest.php
9 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/tests/phpunit/includes/Hooks/MovePageNoticeTest.php
b/client/tests/phpunit/includes/Hooks/MovePageNoticeTest.php
index 2b2436d..a1e164e 100644
--- a/client/tests/phpunit/includes/Hooks/MovePageNoticeTest.php
+++ b/client/tests/phpunit/includes/Hooks/MovePageNoticeTest.php
@@ -10,7 +10,7 @@
use Wikibase\DataModel\SiteLink;
/**
- * @covers Wikibase\Client\Hooks\MovePageNoticeCreator
+ * @covers Wikibase\Client\Hooks\MovePageNotice
*
* @group WikibaseClient
* @group Wikibase
@@ -20,7 +20,7 @@
* @author Katie Filbert < aude.w...@gmail.com >
* @author Marius Hoch < h...@online.de >
*/
-class MovePageNoticeCreatorTest extends \MediaWikiTestCase {
+class MovePageNoticeTest extends \MediaWikiTestCase {
protected function setUp() {
parent::setUp();
diff --git
a/client/tests/phpunit/includes/Hooks/ParserLimitHookHandlersTest.php
b/client/tests/phpunit/includes/Hooks/ParserLimitHookHandlersTest.php
index aeeddd8..1922581 100644
--- a/client/tests/phpunit/includes/Hooks/ParserLimitHookHandlersTest.php
+++ b/client/tests/phpunit/includes/Hooks/ParserLimitHookHandlersTest.php
@@ -7,7 +7,7 @@
use Wikibase\Client\Hooks\ParserLimitHookHandlers;
/**
- * @covers Wikibase\Client\Hooks\ParserLimitHookHandlersTest
+ * @covers Wikibase\Client\Hooks\ParserLimitHookHandlers
*
* @group WikibaseClient
* @group Wikibase
diff --git
a/client/tests/phpunit/includes/Usage/UsageTrackingSnakFormatterTest.php
b/client/tests/phpunit/includes/Usage/UsageTrackingSnakFormatterTest.php
index 66d6055..f27e2d6 100644
--- a/client/tests/phpunit/includes/Usage/UsageTrackingSnakFormatterTest.php
+++ b/client/tests/phpunit/includes/Usage/UsageTrackingSnakFormatterTest.php
@@ -13,7 +13,7 @@
use Wikibase\Lib\SnakFormatter;
/**
- * @covers Wikibase\Lib\Store\UsageTrackingSnakFormatter
+ * @covers Wikibase\Client\Usage\UsageTrackingSnakFormatter
*
* @group Wikibase
* @group WikibaseClient
diff --git a/lib/tests/phpunit/formatters/ErrorHandlingSnakFormatterTest.php
b/lib/tests/phpunit/formatters/ErrorHandlingSnakFormatterTest.php
index 04161f9..5cccd13 100644
--- a/lib/tests/phpunit/formatters/ErrorHandlingSnakFormatterTest.php
+++ b/lib/tests/phpunit/formatters/ErrorHandlingSnakFormatterTest.php
@@ -16,7 +16,7 @@
use Wikibase\Lib\SnakFormatter;
/**
- * @covers Wikibase\Lib\ErrorHandlingSnakFormatter
+ * @covers Wikibase\Lib\Formatters\ErrorHandlingSnakFormatter
*
* @group ValueFormatters
* @group DataValueExtensions
diff --git a/lib/tests/phpunit/sites/SiteMatrixParserTest.php
b/lib/tests/phpunit/sites/SiteMatrixParserTest.php
index 6dfdc4c..005275c 100644
--- a/lib/tests/phpunit/sites/SiteMatrixParserTest.php
+++ b/lib/tests/phpunit/sites/SiteMatrixParserTest.php
@@ -7,7 +7,7 @@
use Wikibase\Lib\Sites\SiteMatrixParser;
/**
- * @covers SiteMatrixParser
+ * @covers Wikibase\Lib\Sites\SiteMatrixParser
*
* @group Wikibase
*
diff --git a/lib/tests/phpunit/sites/SitesBuilderTest.php
b/lib/tests/phpunit/sites/SitesBuilderTest.php
index 622c8e2..ebd7a82 100644
--- a/lib/tests/phpunit/sites/SitesBuilderTest.php
+++ b/lib/tests/phpunit/sites/SitesBuilderTest.php
@@ -8,7 +8,7 @@
use Wikibase\Lib\Sites\SitesBuilder;
/**
- * @covers SitesBuilder
+ * @covers Wikibase\Lib\Sites\SitesBuilder
*
* @group Wikibase
*
diff --git
a/repo/tests/phpunit/includes/LinkedData/EntityDataFormatProviderTest.php
b/repo/tests/phpunit/includes/LinkedData/EntityDataFormatProviderTest.php
index 2f1688f..5f7b253 100644
--- a/repo/tests/phpunit/includes/LinkedData/EntityDataFormatProviderTest.php
+++ b/repo/tests/phpunit/includes/LinkedData/EntityDataFormatProviderTest.php
@@ -5,7 +5,7 @@
use Wikibase\Repo\LinkedData\EntityDataFormatProvider;
/**
- * @covers Wikibase\Repo\LinkedData\EntityDataSerializationService
+ * @covers Wikibase\Repo\LinkedData\EntityDataFormatProvider
*
* @group Database
* @group Wikibase
diff --git
a/repo/tests/phpunit/includes/Notifications/JobQueueChangeNotificationSenderTest.php
b/repo/tests/phpunit/includes/Notifications/JobQueueChangeNotificationSenderTest.php
index 5912bf0..d6ee4be 100644
---
a/repo/tests/phpunit/includes/Notifications/JobQueueChangeNotificationSenderTest.php
+++
b/repo/tests/phpunit/includes/Notifications/JobQueueChangeNotificationSenderTest.php
@@ -3,7 +3,7 @@
namespace Wikibase\Test;
/**
- * @covers Wikibase\Rep\Notifications\JobQueueChangeNotificationSender
+ * @covers Wikibase\Repo\Notifications\JobQueueChangeNotificationSender
*
* @group Wikibase
* @group WikibaseStore
diff --git a/repo/tests/phpunit/includes/StatementRankSerializerTest.php
b/repo/tests/phpunit/includes/StatementRankSerializerTest.php
index 2063eea..e0a9153 100644
--- a/repo/tests/phpunit/includes/StatementRankSerializerTest.php
+++ b/repo/tests/phpunit/includes/StatementRankSerializerTest.php
@@ -10,7 +10,7 @@
use Wikibase\StatementRankSerializer;
/**
- * @covers Wikibase\StatementRankDeserializer
+ * @covers Wikibase\StatementRankSerializer
*
* @group Wikibase
* @group WikibaseRepo
--
To view, visit https://gerrit.wikimedia.org/r/246472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib828a3e45dc809351f218cb6b3c28b330b018c41
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
