Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/246722

Change subject: Revert "Remove existing categories from DOM after the widget 
ate them"
......................................................................

Revert "Remove existing categories from DOM after the widget ate them"

In order to revert "Add categories to sidebar" (781e1896dddf).

This reverts commit 0c71fb6cc62be1dbac81ff918229ff70f6ebb746.

Change-Id: Ibf174999bcd53bcdcf33c87f780a1c75af441211
---
M modules/flow-initialize.js
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/22/246722/1

diff --git a/modules/flow-initialize.js b/modules/flow-initialize.js
index ee30eea..e3fe1bf 100644
--- a/modules/flow-initialize.js
+++ b/modules/flow-initialize.js
@@ -118,6 +118,12 @@
                } );
                $( '.flow-board-navigation' ).append( navWidget.$element );
 
+               // The category widget is inside the board description widget.
+               // Remove it here
+               $( '.flow-board-header-category-view-nojs' ).detach();
+               // HACK: Remove the MW page categories
+               $( '.catlinks' ).detach();
+
                // HACK: These event handlers should be in the prospective 
widgets
                // they will move once we have Board UI and Topic UI widgets
                mw.flow.system.on( 'resetBoardStart', function () {
@@ -561,12 +567,6 @@
                        $categories: $( '.flow-board-header-category-view-nojs' 
).contents()
                } );
                $( '.flow-ui-boardDescriptionWidget' ).replaceWith( 
descriptionWidget.$element );
-
-               // The category widget is inside the board description widget.
-               // Remove it here
-               $( '.flow-board-header-category-view-nojs' ).detach();
-               // HACK: Remove the MW page categories
-               $( '.catlinks' ).detach();
 
                preloadTopic = OO.getProp( dataBlob, 'blocks', 'topiclist', 
'submitted', 'topic' );
                preloadContent = OO.getProp( dataBlob, 'blocks', 'topiclist', 
'submitted', 'content' );

-- 
To view, visit https://gerrit.wikimedia.org/r/246722
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf174999bcd53bcdcf33c87f780a1c75af441211
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: wmf/1.27.0-wmf.3
Gerrit-Owner: Catrope <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to