Cscott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/246852
Change subject: WIP: T108504 normalize before comparing link
......................................................................
WIP: T108504 normalize before comparing link
Change-Id: I50f3c380f51e6751523ab58386d864fb04461997
---
M lib/wts.LinkHandler.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/52/246852/1
diff --git a/lib/wts.LinkHandler.js b/lib/wts.LinkHandler.js
index e1c6632..cad58a4 100644
--- a/lib/wts.LinkHandler.js
+++ b/lib/wts.LinkHandler.js
@@ -779,6 +779,8 @@
if (linkElt && linkElt.hasAttribute('href')) {
link = this.serializedImageAttrVal(outerElt, linkElt, 'href');
if (!link.fromsrc) {
+ // XXX we should normalize the href to a title here
before
+ // comparing: T108504
if (linkElt.getAttribute('href') ===
imgElt.getAttribute('resource')) {
// default link: same place as resource
link = resource;
--
To view, visit https://gerrit.wikimedia.org/r/246852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50f3c380f51e6751523ab58386d864fb04461997
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
