Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/246861
Change subject: clone is not a function
......................................................................
clone is not a function
Remove parenthesis around clone magic word
Change-Id: I2e0e53303f7c73745bd1ab4bcf32e74943efc4de
---
M includes/Linker.php
M includes/exception/ErrorPageError.php
M includes/page/ImagePage.php
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/61/246861/1
diff --git a/includes/Linker.php b/includes/Linker.php
index e821004..842d276 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -1469,7 +1469,7 @@
if ( $target->getText() == ''
&& !$target->isExternal()
&& !$local && $title
) {
- $newTarget = clone (
$title );
+ $newTarget = clone
$title;
$newTarget->setFragment( '#' . $target->getFragment() );
$target = $newTarget;
}
diff --git a/includes/exception/ErrorPageError.php
b/includes/exception/ErrorPageError.php
index 3631a34..6366c74 100644
--- a/includes/exception/ErrorPageError.php
+++ b/includes/exception/ErrorPageError.php
@@ -44,7 +44,7 @@
// passing to the parent constructor. Our overridden report()
below
// makes sure that the page shown to the user is not forced to
English.
if ( $msg instanceof Message ) {
- $enMsg = clone( $msg );
+ $enMsg = clone $msg;
} else {
$enMsg = wfMessage( $msg, $params );
}
diff --git a/includes/page/ImagePage.php b/includes/page/ImagePage.php
index 7957e65..3638aed 100644
--- a/includes/page/ImagePage.php
+++ b/includes/page/ImagePage.php
@@ -1533,7 +1533,7 @@
function __construct( $imagePage ) {
parent::__construct( $imagePage->getContext() );
$this->mImagePage = $imagePage;
- $this->mTitle = clone ( $imagePage->getTitle() );
+ $this->mTitle = clone $imagePage->getTitle();
$this->mTitle->setFragment( '#filehistory' );
$this->mImg = null;
$this->mHist = array();
--
To view, visit https://gerrit.wikimedia.org/r/246861
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e0e53303f7c73745bd1ab4bcf32e74943efc4de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
