Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247044
Change subject: Enable EventLogging for backtotop and re-enable for font-changer
......................................................................
Enable EventLogging for backtotop and re-enable for font-changer
BackToTop: Log clicks on the back to top arrow to see, if it's used or not.
FontChanger: With the last change of FontChanger, changes aren't logged
anymore. Re-Enable logging with the same event name.
Follow-up: I6d73a591ed9adb55de
Bug: T98701
Change-Id: Id5d9d30725cc2cacbe3a2abc83175b56b6f15470
---
M includes/Resources.php
M resources/mobile.backtotop/BackToTopOverlay.js
M resources/mobile.fontchanger/FontChanger.js
3 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/44/247044/1
diff --git a/includes/Resources.php b/includes/Resources.php
index dad4e7b..c579d97 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -399,6 +399,7 @@
'dependencies' => array(
'mobile.startup',
'mobile.toggle',
+ 'mobile.loggingSchemas',
),
'scripts' => array(
'resources/mobile.backtotop/BackToTopOverlay.js',
diff --git a/resources/mobile.backtotop/BackToTopOverlay.js
b/resources/mobile.backtotop/BackToTopOverlay.js
index c39e320..ae2f0a6 100644
--- a/resources/mobile.backtotop/BackToTopOverlay.js
+++ b/resources/mobile.backtotop/BackToTopOverlay.js
@@ -1,7 +1,9 @@
( function ( M, $ ) {
var BackToTopOverlay,
- View = M.require( 'mobile.view/View' );
+ View = M.require( 'mobile.view/View' ),
+ MobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
+ uiSchema = new MobileWebClickTracking( {},
'MobileWebUIClickTracking' );
/**
* Displays a little arrow at the bottom right of the viewport.
@@ -44,6 +46,9 @@
*/
onBackToTopClick: function () {
$( 'html, body' ).animate( { scrollTop: 0 }, 400 );
+ uiSchema.log( {
+ name: 'backtotop-click'
+ } );
}
} );
diff --git a/resources/mobile.fontchanger/FontChanger.js
b/resources/mobile.fontchanger/FontChanger.js
index dff22d2..c0b71c0 100644
--- a/resources/mobile.fontchanger/FontChanger.js
+++ b/resources/mobile.fontchanger/FontChanger.js
@@ -2,7 +2,9 @@
var FontChanger,
View = M.require( 'mobile.view/View' ),
Button = M.require( 'mobile.startup/Button' ),
- settings = M.require( 'mobile.settings/settings' );
+ settings = M.require( 'mobile.settings/settings' ),
+ MobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
+ uiSchema = new MobileWebClickTracking( {},
'MobileWebUIClickTracking' );
/**
* FontChanger wrapper
@@ -77,6 +79,10 @@
* @param {Number} percentage New percentage value
*/
setPercentage: function ( percentage ) {
+ // log, that the user want to change the font size
+ uiSchema.log( {
+ name: 'fontchanger-font-change'
+ } );
// disallow changes under 10% and over 200%
if ( percentage > 9 && percentage < 201 ) {
this.fontchanger
--
To view, visit https://gerrit.wikimedia.org/r/247044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5d9d30725cc2cacbe3a2abc83175b56b6f15470
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
