Alexandros Kosiaris has submitted this change and it was merged.
Change subject: backup::storage: Move base::firewall include inside the role
......................................................................
backup::storage: Move base::firewall include inside the role
Change-Id: If4efa68e96cd8136f1ec9d9e20ae0c53bd8ae6c2
---
M manifests/role/backup.pp
M manifests/site.pp
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexandros Kosiaris: Verified; Looks good to me, approved
diff --git a/manifests/role/backup.pp b/manifests/role/backup.pp
index 382f920..aa32bd3 100644
--- a/manifests/role/backup.pp
+++ b/manifests/role/backup.pp
@@ -266,6 +266,7 @@
class role::backup::storage() {
include role::backup::config
+ include base::firewall
system::role { 'role::backup::storage': description => 'Backup Storage' }
diff --git a/manifests/site.pp b/manifests/site.pp
index 60f09c0..c7dccfa 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1071,7 +1071,6 @@
node 'heze.codfw.wmnet' {
role backup::storage
include standard
- include base::firewall
}
# Holmium hosts openstack-designate, the labs DNS service.
--
To view, visit https://gerrit.wikimedia.org/r/247259
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4efa68e96cd8136f1ec9d9e20ae0c53bd8ae6c2
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
