jenkins-bot has submitted this change and it was merged.
Change subject: Fix tests in TimedMediaHandler
......................................................................
Fix tests in TimedMediaHandler
This adds ine missing tests to the required list in TimedMediaHandler, It
adds TestWebMHandler.php test.
Also fix class in TestWebMHandler.php which had class TestOggHandler which
was used by another file in TimedMediaHandler so it would fail the jenkins
tests so changed the class to TestWebMHandler which now passes jenkins.
Also update the test to support some recent changes done to
TimedMediaHandler.
Change-Id: Ibe4a423e0bcb1f2a416707609fa42b41d8f90b83
---
M TimedMediaHandler.hooks.php
M tests/phpunit/TestWebMHandler.php
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Reedy: Looks good to me, approved
Brion VIBBER: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index 6acfe41..53df14a 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -403,6 +403,7 @@
'TestVideoThumbnail.php',
'TestVideoTranscode.php',
'TestOggHandler.php',
+ 'TestWebMHandler.php',
'TestTimedMediaTransformOutput.php',
'TestTimedMediaHandler.php'
);
diff --git a/tests/phpunit/TestWebMHandler.php
b/tests/phpunit/TestWebMHandler.php
index 2d73f46..b044d04 100644
--- a/tests/phpunit/TestWebMHandler.php
+++ b/tests/phpunit/TestWebMHandler.php
@@ -1,5 +1,5 @@
<?php
-class TestOggHandler extends MediaWikiMediaTestCase {
+class TestWebMHandler extends MediaWikiMediaTestCase {
/** @var OggHandlerTMH */
private $handler;
@@ -27,7 +27,7 @@
return array(
array( 'shuttle10seconds.1080x608.webm', array( 'VP8' )
),
array( 'VP9-tractor.webm', array( 'VP9' ) ),
- array( 'bear-vp9-opus.webm', array( 'Opus', 'VP9' ) )
+ array( 'bear-vp9-opus.webm', array( 'VP9', 'Opus' ) )
);
}
@@ -46,7 +46,7 @@
return array(
array( 'shuttle10seconds.1080x608.webm', 'video/webm;
codecs="vp8"' ),
array( 'VP9-tractor.webm', 'video/webm; codecs="vp9"' ),
- array( 'bear-vp9-opus.webm', 'video/webm; codecs="opus,
vp9"' )
+ array( 'bear-vp9-opus.webm', 'video/webm; codecs="vp9,
opus"' )
);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/247292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe4a423e0bcb1f2a416707609fa42b41d8f90b83
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
