Brion VIBBER has submitted this change and it was merged.
Change subject: Turn MwEmbed loaderscripts into modules
......................................................................
Turn MwEmbed loaderscripts into modules
Cross dependency with I2768861e387013dd4411e7d1093f0fff9c9b7b6b
Bug: T74675
Change-Id: Ib3360fa9271b9452cec5e86281c2859f7e0f464e
---
M MwEmbedResourceManager.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Paladox: Looks good to me, but someone else must approve
Brion VIBBER: Looks good to me, approved
Objections:
MarkTraceur: There's a problem with this change, please improve
diff --git a/MwEmbedResourceManager.php b/MwEmbedResourceManager.php
index 79503a2..c9b5a1b 100644
--- a/MwEmbedResourceManager.php
+++ b/MwEmbedResourceManager.php
@@ -58,8 +58,9 @@
// Check for module loader:
if ( is_file( $localResourcePath . '/' . $moduleName .
'.loader.js' ) ) {
- $resourceList[$moduleName . '.loader'] = array(
- 'loaderScripts' => $moduleName . '.loader.js'
+ $resourceList['mw.' . $moduleName . '.loader'] = array(
+ 'scripts' => $moduleName . '.loader.js',
+ 'position' => 'top',
);
}
--
To view, visit https://gerrit.wikimedia.org/r/172556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3360fa9271b9452cec5e86281c2859f7e0f464e
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/MwEmbedSupport
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: Mdale <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
