jenkins-bot has submitted this change and it was merged.

Change subject: Remove DeferredUpdates::doUpdates call in CLI scripts
......................................................................


Remove DeferredUpdates::doUpdates call in CLI scripts

Core already handles this by not letting them build up.
They run after each main DB commit.

Change-Id: I37c2a60e2df579ed59b2a8f3a7679d1d380e6337
---
M maintenance/importDump.php
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/maintenance/importDump.php b/maintenance/importDump.php
index ea8c84b..bf59495 100644
--- a/maintenance/importDump.php
+++ b/maintenance/importDump.php
@@ -235,8 +235,6 @@
                        }
                }
                wfWaitForSlaves();
-               // XXX: Don't let deferred jobs array get absurdly large (bug 
24375)
-               DeferredUpdates::doUpdates( 'commit' );
        }
 
        function progress( $string ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/247625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I37c2a60e2df579ed59b2a8f3a7679d1d380e6337
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: TTO <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to