jenkins-bot has submitted this change and it was merged. Change subject: Use $().text() when we want text ......................................................................
Use $().text() when we want text Changing these from .append() is fine because they're all empty at this point Change-Id: If4884bf254e6168eb727aaf192c0e739592e4d6b --- M resources/mw.UploadWizardDetails.js 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: MarkTraceur: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/mw.UploadWizardDetails.js b/resources/mw.UploadWizardDetails.js index b66af93..e0030e7 100644 --- a/resources/mw.UploadWizardDetails.js +++ b/resources/mw.UploadWizardDetails.js @@ -130,7 +130,7 @@ categoriesHinter = function () { return categoriesHint; }; $categoriesDiv .find( '.mwe-upwiz-details-fieldname' ) - .append( mw.message( 'mwe-upwiz-categories' ).escaped() ) + .text( mw.message( 'mwe-upwiz-categories' ).text() ) .addHint( 'mwe-upwiz-categories-hint', categoriesHinter ); dateInputId = 'dateInput' + ( this.upload.index ).toString(); @@ -191,8 +191,8 @@ }; locationDiv = $( '<div class="mwe-location mwe-upwiz-details-fieldname-input ui-helper-clearfix"></div>' ) - .append( $ ('<div class="mwe-location-label"></div>' ) - .append( mw.message( 'mwe-upwiz-location' ).escaped() ) + .append( $( '<div class="mwe-location-label"></div>' ) + .text( mw.message( 'mwe-upwiz-location' ).text() ) .addHint( 'location', locationHinter ) ) .append( @@ -206,8 +206,8 @@ this.$longitudeInput = this.makeLocationField( 'lon', locationDiv ); this.$headingInput = this.makeLocationField( 'heading', locationDiv ); - showMap = $( '<a></a>' ) - .append( mw.message( 'mwe-upwiz-location-button' ).text() ) + showMap = $( '<a>' ) + .text( mw.message( 'mwe-upwiz-location-button' ).text() ) .hide(); linkDiv = $( '<div class="mwe-loc-link"></div>' ) -- To view, visit https://gerrit.wikimedia.org/r/246233 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4884bf254e6168eb727aaf192c0e739592e4d6b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: MarkTraceur <mtrac...@member.fsf.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits