Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247636
Change subject: Rename JobQueue::doAck() to to JobQueue::markJobComplete()
......................................................................
Rename JobQueue::doAck() to to JobQueue::markJobComplete()
Clarity.
Change-Id: I1db3c3166bf68cd97879cee3cd17291086ddbba8
---
M includes/jobqueue/JobQueue.php
M includes/jobqueue/JobQueueDB.php
M includes/jobqueue/JobQueueFederated.php
M includes/jobqueue/JobQueueRedis.php
4 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/36/247636/1
diff --git a/includes/jobqueue/JobQueue.php b/includes/jobqueue/JobQueue.php
index 69a3def..0b6c0d5 100644
--- a/includes/jobqueue/JobQueue.php
+++ b/includes/jobqueue/JobQueue.php
@@ -395,14 +395,14 @@
if ( $job->getType() !== $this->type ) {
throw new MWException( "Got '{$job->getType()}' job;
expected '{$this->type}'." );
}
- $this->doAck( $job );
+ $this->markJobComplete( $job );
}
/**
* @see JobQueue::ack()
* @param Job $job
*/
- abstract protected function doAck( Job $job );
+ abstract protected function markJobComplete( Job $job );
/**
* Register the "root job" of a given job into the queue for
de-duplication.
diff --git a/includes/jobqueue/JobQueueDB.php b/includes/jobqueue/JobQueueDB.php
index 7907614..cf0912f 100644
--- a/includes/jobqueue/JobQueueDB.php
+++ b/includes/jobqueue/JobQueueDB.php
@@ -454,12 +454,12 @@
}
/**
- * @see JobQueue::doAck()
+ * @see JobQueue::markJobComplete()
* @param Job $job
* @throws MWException
* @return Job|bool
*/
- protected function doAck( Job $job ) {
+ protected function markJobComplete( Job $job ) {
if ( !isset( $job->metadata['id'] ) ) {
throw new MWException( "Job of type '{$job->getType()}'
has no ID." );
}
diff --git a/includes/jobqueue/JobQueueFederated.php
b/includes/jobqueue/JobQueueFederated.php
index 109ca01..eddafb9 100644
--- a/includes/jobqueue/JobQueueFederated.php
+++ b/includes/jobqueue/JobQueueFederated.php
@@ -306,7 +306,7 @@
return false;
}
- protected function doAck( Job $job ) {
+ protected function markJobComplete( Job $job ) {
if ( !isset( $job->metadata['QueuePartition'] ) ) {
throw new MWException( "The given job has no defined
partition name." );
}
diff --git a/includes/jobqueue/JobQueueRedis.php
b/includes/jobqueue/JobQueueRedis.php
index 29c8068..3bbc76f 100644
--- a/includes/jobqueue/JobQueueRedis.php
+++ b/includes/jobqueue/JobQueueRedis.php
@@ -354,13 +354,13 @@
}
/**
- * @see JobQueue::doAck()
+ * @see JobQueue::markJobComplete()
* @param Job $job
* @return Job|bool
* @throws UnexpectedValueException
* @throws JobQueueError
*/
- protected function doAck( Job $job ) {
+ protected function markJobComplete( Job $job ) {
if ( !isset( $job->metadata['uuid'] ) ) {
throw new UnexpectedValueException( "Job of type
'{$job->getType()}' has no UUID." );
}
--
To view, visit https://gerrit.wikimedia.org/r/247636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1db3c3166bf68cd97879cee3cd17291086ddbba8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
