Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247638
Change subject: Rename and simplify jobqueue 'job-ack' metric
......................................................................
Rename and simplify jobqueue 'job-ack' metric
The MediaWiki job queue is one of the most highly-instrumented components in
our stack, and yet as T116001 shows, it often crosses crisis thresholds without
anyone noticing (apart from users, that is!), and responders are not sure which
metrics to look at in order to understand current conditions.
This suggests to me that we need to radically simplify our instrumentation of
the job queue. One thing that seems like a mistake in hindsight is emitting
per-job-type metrics. Although these can be aggregated into a holistic view,
they still have a tendency to overwhelm by dint of their sheer number. Someone
browsing the metrics on Graphite should be able to quicky identify and navigate
to the most critical metrics, as opposed to having to construct them using
Graphite queries, or having to fish for the 'all' sub-metric nested within a
long list of peers.
More granular views on the state of the job queue should be the job of
command-line debugging tools like showJobs.php.
I intend to follow up by making similar changes to other job queue metrics.
Change-Id: Idf0ad9742dea3c5acb19a61aaa4f787e0496b675
---
M includes/jobqueue/JobQueueRedis.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/38/247638/1
diff --git a/includes/jobqueue/JobQueueRedis.php
b/includes/jobqueue/JobQueueRedis.php
index 3bbc76f..bd0748d 100644
--- a/includes/jobqueue/JobQueueRedis.php
+++ b/includes/jobqueue/JobQueueRedis.php
@@ -393,7 +393,7 @@
return false;
}
- JobQueue::incrStats( 'job-ack', $this->type );
+ JobQueue::incrStats( 'jobs.completed' );
} catch ( RedisException $e ) {
$this->throwRedisException( $conn, $e );
}
--
To view, visit https://gerrit.wikimedia.org/r/247638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf0ad9742dea3c5acb19a61aaa4f787e0496b675
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
