Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247724
Change subject: Simplify SpecialListProperties::getSubpagesForPrefixSearch
......................................................................
Simplify SpecialListProperties::getSubpagesForPrefixSearch
This also fixes the tests, as the tests assume this will be an
assoc array, but it no longer is (since DataTypes 0.5.1).
Change-Id: I93dea62102760ef4f4fca1ea2ab76dab6d611420
---
M repo/includes/specials/SpecialListProperties.php
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/24/247724/1
diff --git a/repo/includes/specials/SpecialListProperties.php
b/repo/includes/specials/SpecialListProperties.php
index 424bb72..cd77797 100644
--- a/repo/includes/specials/SpecialListProperties.php
+++ b/repo/includes/specials/SpecialListProperties.php
@@ -273,9 +273,7 @@
* @see SpecialPage::getSubpagesForPrefixSearch
*/
protected function getSubpagesForPrefixSearch() {
- return array_map( function ( $dataType ) {
- return $dataType->getId();
- }, $this->dataTypeFactory->getTypes() );
+ return $this->dataTypeFactory->getTypeIds();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/247724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93dea62102760ef4f4fca1ea2ab76dab6d611420
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
