saper has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247728
Change subject: Split mediawiki.special.preferences
......................................................................
Split mediawiki.special.preferences
- mediawiki.special.preferences.tab.js
generates table of contents and needs
to be loaded early
- mediawiki.special.preferences.js
additional scripts that can be loaded
at the bottom
- mediawiki.special.preferences.timezone.js
timezone functions to be loaded late
Change-Id: Ib58d2bf9fb4dbb32412adc29cd2384e106b2119a
---
M includes/specials/SpecialPreferences.php
M resources/Resources.php
M resources/src/mediawiki.special/mediawiki.special.preferences.js
A resources/src/mediawiki.special/mediawiki.special.preferences.tab.js
A resources/src/mediawiki.special/mediawiki.special.preferences.timezone.js
5 files changed, 311 insertions(+), 285 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/28/247728/1
diff --git a/includes/specials/SpecialPreferences.php
b/includes/specials/SpecialPreferences.php
index 4b75e5f..3c96c6d 100644
--- a/includes/specials/SpecialPreferences.php
+++ b/includes/specials/SpecialPreferences.php
@@ -46,7 +46,9 @@
return;
}
+ $out->addModules( 'mediawiki.special.preferences.tab' );
$out->addModules( 'mediawiki.special.preferences' );
+ $out->addModules( 'mediawiki.special.preferences.timezone' );
if ( $this->getRequest()->getCheck( 'success' ) ) {
$out->wrapWikiMsg(
diff --git a/resources/Resources.php b/resources/Resources.php
index fee1e7c..91236dd 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1707,22 +1707,35 @@
'position' => 'top',
'styles' =>
'resources/src/mediawiki.special/mediawiki.special.pagesWithProp.css',
),
- 'mediawiki.special.preferences' => array(
- 'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.preferences.js',
+ 'mediawiki.special.preferences.tab' => array(
+ 'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.preferences.tab.js',
'styles' =>
'resources/src/mediawiki.special/mediawiki.special.preferences.css',
'position' => 'top',
'messages' => array(
'prefs-tabs-navigation-hint',
- 'prefswarning-warning',
- 'saveprefs',
'savedprefs',
),
'dependencies' => array(
- 'mediawiki.language',
- 'mediawiki.confirmCloseWindow',
'mediawiki.notification',
),
),
+ 'mediawiki.special.preferences' => array(
+ 'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.preferences.js',
+ 'messages' => array(
+ 'prefswarning-warning',
+ 'saveprefs',
+ ),
+ 'dependencies' => array(
+ 'mediawiki.special.preferences.tab',
+ 'mediawiki.confirmCloseWindow',
+ ),
+ ),
+ 'mediawiki.special.preferences.timezone' => array(
+ 'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.preferences.timezone.js',
+ 'dependencies' => array(
+ 'mediawiki.language',
+ ),
+ ),
'mediawiki.special.recentchanges' => array(
'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.recentchanges.js',
'dependencies' => 'mediawiki.special',
diff --git a/resources/src/mediawiki.special/mediawiki.special.preferences.js
b/resources/src/mediawiki.special/mediawiki.special.preferences.js
index 0fda3dc..30d29f5 100644
--- a/resources/src/mediawiki.special/mediawiki.special.preferences.js
+++ b/resources/src/mediawiki.special/mediawiki.special.preferences.js
@@ -3,287 +3,10 @@
*/
( function ( mw, $ ) {
$( function () {
- var $preftoc, $preferences, $fieldsets, $legends,
- hash, labelFunc,
- $tzSelect, $tzTextbox, $localtimeHolder, servertime,
- $checkBoxes, allowCloseWindow,
- notif;
-
- labelFunc = function () {
- return this.id.replace( /^mw-prefsection/g, 'preftab' );
- };
-
- $( '#prefsubmit' ).attr( 'id', 'prefcontrol' );
- $preftoc = $( '<ul>' )
- .attr( {
- id: 'preftoc',
- role: 'tablist'
- } );
- $preferences = $( '#preferences' )
- .addClass( 'jsprefs' )
- .before( $preftoc );
- $fieldsets = $preferences.children( 'fieldset' )
- .hide()
- .attr( {
- role: 'tabpanel',
- 'aria-hidden': 'true',
- 'aria-labelledby': labelFunc
- } )
- .addClass( 'prefsection' );
- $legends = $fieldsets
- .children( 'legend' )
- .addClass( 'mainLegend' );
-
- // Make sure the accessibility tip is selectable so that screen
reader users take notice,
- // but hide it per default to reduce interface clutter. Also
make sure it becomes visible
- // when selected. Similar to jquery.mw-jump
- $( '<div>' ).addClass( 'mw-navigation-hint' )
- .text( mw.msg( 'prefs-tabs-navigation-hint' ) )
- .attr( 'tabIndex', 0 )
- .on( 'focus blur', function ( e ) {
- if ( e.type === 'blur' || e.type === 'focusout'
) {
- $( this ).css( 'height', '0' );
- } else {
- $( this ).css( 'height', 'auto' );
- }
- } ).insertBefore( $preftoc );
-
- /**
- * It uses document.getElementById for security reasons (HTML
injections in $()).
- *
- * @ignore
- * @param {string} name the name of a tab without the prefix
("mw-prefsection-")
- * @param {string} [mode] A hash will be set according to the
current
- * open section. Set mode 'noHash' to surpress this.
- */
- function switchPrefTab( name, mode ) {
- var $tab, scrollTop;
- // Handle hash manually to prevent jumping,
- // therefore save and restore scrollTop to prevent
jumping.
- scrollTop = $( window ).scrollTop();
- if ( mode !== 'noHash' ) {
- location.hash = '#mw-prefsection-' + name;
- }
- $( window ).scrollTop( scrollTop );
-
- $preftoc.find( 'li' ).removeClass( 'selected' )
- .find( 'a' ).attr( {
- tabIndex: -1,
- 'aria-selected': 'false'
- } );
-
- $tab = $( document.getElementById( 'preftab-' + name )
);
- if ( $tab.length ) {
- $tab.attr( {
- tabIndex: 0,
- 'aria-selected': 'true'
- } )
- .focus()
- .parent().addClass( 'selected' );
-
- $preferences.children( 'fieldset'
).hide().attr( 'aria-hidden', 'true' );
- $( document.getElementById( 'mw-prefsection-' +
name ) ).show().attr( 'aria-hidden', 'false' );
- }
- }
-
- // Check for messageboxes (.successbox, .warningbox, .errorbox)
to replace with notifications
- if ( $( '.mw-preferences-messagebox' ).length ) {
- // If there is a #mw-preferences-success box and
javascript is enabled, use a slick notification instead!
- if ( $( '#mw-preferences-success' ).length ) {
- notif = mw.notification.notify( mw.message(
'savedprefs' ), { autoHide: false } );
- // 'change' event not reliable!
- $( '#preftoc, .prefsection' ).one( 'change
keydown mousedown', function () {
- if ( notif ) {
- notif.close();
- notif = null;
- }
- } );
-
- // Remove now-unnecessary success=1 querystring
to prevent reappearance of notification on reload
- if ( history.replaceState ) {
- history.replaceState( {},
document.title, location.href.replace( /&?success=1/, '' ) );
- }
- }
- }
-
- // Populate the prefToc
- $legends.each( function ( i, legend ) {
- var $legend = $( legend ),
- ident, $li, $a;
- if ( i === 0 ) {
- $legend.parent().show();
- }
- ident = $legend.parent().attr( 'id' );
-
- $li = $( '<li>' )
- .attr( 'role', 'presentation' )
- .addClass( i === 0 ? 'selected' : '' );
- $a = $( '<a>' )
- .attr( {
- id: ident.replace( 'mw-prefsection',
'preftab' ),
- href: '#' + ident,
- role: 'tab',
- tabIndex: i === 0 ? 0 : -1,
- 'aria-selected': i === 0 ? 'true' :
'false',
- 'aria-controls': ident
- } )
- .text( $legend.text() );
- $li.append( $a );
- $preftoc.append( $li );
- } );
-
- // Disable the button to save preferences unless preferences
have changed
- $( '#prefcontrol' ).prop( 'disabled', true );
- $( '.prefsection' ).one( 'change keydown mousedown', function
() {
- $( '#prefcontrol' ).prop( 'disabled', false );
- } );
-
- // Enable keyboard users to use left and right keys to switch
tabs
- $preftoc.on( 'keydown', function ( event ) {
- var keyLeft = 37,
- keyRight = 39,
- $el;
-
- if ( event.keyCode === keyLeft ) {
- $el = $( '#preftoc li.selected' ).prev().find(
'a' );
- } else if ( event.keyCode === keyRight ) {
- $el = $( '#preftoc li.selected' ).next().find(
'a' );
- } else {
- return;
- }
- if ( $el.length > 0 ) {
- switchPrefTab( $el.attr( 'href' ).replace(
'#mw-prefsection-', '' ) );
- }
- } );
-
- // If we've reloaded the page or followed an open-in-new-window,
- // make the selected tab visible.
- hash = location.hash;
- if ( hash.match( /^#mw-prefsection-[\w\-]+/ ) ) {
- switchPrefTab( hash.replace( '#mw-prefsection-', '' ) );
- }
-
- // In browsers that support the onhashchange event we will not
bind click
- // handlers and instead let the browser do the default behavior
(clicking the
- // <a href="#.."> will naturally set the hash, handled by
onhashchange.
- // But other things that change the hash will also be catched
(e.g. using
- // the Back and Forward browser navigation).
- // Note the special check for IE "compatibility" mode.
- if ( 'onhashchange' in window &&
- ( document.documentMode === undefined ||
document.documentMode >= 8 )
- ) {
- $( window ).on( 'hashchange', function () {
- var hash = location.hash;
- if ( hash.match( /^#mw-prefsection-[\w\-]+/ ) )
{
- switchPrefTab( hash.replace(
'#mw-prefsection-', '' ) );
- } else if ( hash === '' ) {
- switchPrefTab( 'personal', 'noHash' );
- }
- } );
- // In older browsers we'll bind a click handler as fallback.
- // We must not have onhashchange *and* the click handlers,
other wise
- // the click handler calls switchPrefTab() which sets the hash
value,
- // which triggers onhashcange and calls switchPrefTab() again.
- } else {
- $preftoc.on( 'click', 'li a', function ( e ) {
- switchPrefTab( $( this ).attr( 'href'
).replace( '#mw-prefsection-', '' ) );
- e.preventDefault();
- } );
- }
-
- // Timezone functions.
- // Guesses Timezone from browser and updates fields onchange.
-
- $tzSelect = $( '#mw-input-wptimecorrection' );
- $tzTextbox = $( '#mw-input-wptimecorrection-other' );
- $localtimeHolder = $( '#wpLocalTime' );
- servertime = parseInt( $( 'input[name="wpServerTime"]' ).val(),
10 );
-
- function minutesToHours( min ) {
- var tzHour = Math.floor( Math.abs( min ) / 60 ),
- tzMin = Math.abs( min ) % 60,
- tzString = ( ( min >= 0 ) ? '' : '-' ) + ( (
tzHour < 10 ) ? '0' : '' ) + tzHour +
- ':' + ( ( tzMin < 10 ) ? '0' : '' ) +
tzMin;
- return tzString;
- }
-
- function hoursToMinutes( hour ) {
- var minutes,
- arr = hour.split( ':' );
-
- arr[ 0 ] = parseInt( arr[ 0 ], 10 );
-
- if ( arr.length === 1 ) {
- // Specification is of the form [-]XX
- minutes = arr[ 0 ] * 60;
- } else {
- // Specification is of the form [-]XX:XX
- minutes = Math.abs( arr[ 0 ] ) * 60 + parseInt(
arr[ 1 ], 10 );
- if ( arr[ 0 ] < 0 ) {
- minutes *= -1;
- }
- }
- // Gracefully handle non-numbers.
- if ( isNaN( minutes ) ) {
- return 0;
- } else {
- return minutes;
- }
- }
-
- function updateTimezoneSelection() {
- var minuteDiff, localTime,
- type = $tzSelect.val();
-
- if ( type === 'guess' ) {
- // Get browser timezone & fill it in
- minuteDiff = -( new Date().getTimezoneOffset()
);
- $tzTextbox.val( minutesToHours( minuteDiff ) );
- $tzSelect.val( 'other' );
- $tzTextbox.prop( 'disabled', false );
- } else if ( type === 'other' ) {
- // Grab data from the textbox, parse it.
- minuteDiff = hoursToMinutes( $tzTextbox.val() );
- } else {
- // Grab data from the $tzSelect value
- minuteDiff = parseInt( type.split( '|' )[ 1 ],
10 ) || 0;
- $tzTextbox.val( minutesToHours( minuteDiff ) );
- }
-
- // Determine local time from server time and minutes
difference, for display.
- localTime = servertime + minuteDiff;
-
- // Bring time within the [0,1440) range.
- localTime = ( ( localTime % 1440 ) + 1440 ) % 1440;
-
- $localtimeHolder.text( mw.language.convertNumber(
minutesToHours( localTime ) ) );
- }
-
- if ( $tzSelect.length && $tzTextbox.length ) {
- $tzSelect.change( updateTimezoneSelection );
- $tzTextbox.blur( updateTimezoneSelection );
- updateTimezoneSelection();
- }
-
- // Preserve the tab after saving the preferences
- // Not using cookies, because their deletion results are
inconsistent.
- // Not using jStorage due to its enormous size (for this
feature)
- if ( window.sessionStorage ) {
- if ( sessionStorage.getItem( 'mediawikiPreferencesTab'
) !== null ) {
- switchPrefTab( sessionStorage.getItem(
'mediawikiPreferencesTab' ), 'noHash' );
- }
- // Deleting the key, the tab states should be reset
until we press Save
- sessionStorage.removeItem( 'mediawikiPreferencesTab' );
-
- $( '#mw-prefs-form' ).submit( function () {
- var storageData = $( $preftoc ).find(
'li.selected a' ).attr( 'id' ).replace( 'preftab-', '' );
- sessionStorage.setItem(
'mediawikiPreferencesTab', storageData );
- } );
- }
// To disable all 'namespace' checkboxes in Search preferences
// when 'Search in all namespaces' checkbox is ticked.
- $checkBoxes = $( '#mw-htmlform-advancedsearchoptions
input[id^=mw-input-wpsearchnamespaces]' );
+ var $checkBoxes = $( '#mw-htmlform-advancedsearchoptions
input[id^=mw-input-wpsearchnamespaces]' );
if ( $( '#mw-input-wpsearcheverything' ).prop( 'checked' ) ) {
$checkBoxes.prop( 'disabled', true );
}
@@ -294,7 +17,7 @@
// Set up a message to notify users if they try to leave the
page without
// saving.
$( '#mw-prefs-form' ).data( 'origdata', $( '#mw-prefs-form'
).serialize() );
- allowCloseWindow = mw.confirmCloseWindow( {
+ var allowCloseWindow = mw.confirmCloseWindow( {
test: function () {
return $( '#mw-prefs-form' ).serialize() !== $(
'#mw-prefs-form' ).data( 'origdata' );
},
diff --git
a/resources/src/mediawiki.special/mediawiki.special.preferences.tab.js
b/resources/src/mediawiki.special/mediawiki.special.preferences.tab.js
new file mode 100644
index 0000000..8a2b4e2
--- /dev/null
+++ b/resources/src/mediawiki.special/mediawiki.special.preferences.tab.js
@@ -0,0 +1,206 @@
+/*!
+ * JavaScript for Special:Preferences
+ * This script is loaded at the top of the page,
+ * keep as small as possible.
+ */
+( function ( mw, $ ) {
+ $( function () {
+ var $preftoc, $preferences, $fieldsets, $legends;
+
+ var labelFunc = function () {
+ return this.id.replace( /^mw-prefsection/g, 'preftab' );
+ };
+
+ $( '#prefsubmit' ).attr( 'id', 'prefcontrol' );
+ $preftoc = $( '<ul>' )
+ .attr( {
+ id: 'preftoc',
+ role: 'tablist'
+ } );
+ $preferences = $( '#preferences' )
+ .addClass( 'jsprefs' )
+ .before( $preftoc );
+ $fieldsets = $preferences.children( 'fieldset' )
+ .hide()
+ .attr( {
+ role: 'tabpanel',
+ 'aria-hidden': 'true',
+ 'aria-labelledby': labelFunc
+ } )
+ .addClass( 'prefsection' );
+ $legends = $fieldsets
+ .children( 'legend' )
+ .addClass( 'mainLegend' );
+
+ // Make sure the accessibility tip is selectable so that screen
reader users take notice,
+ // but hide it per default to reduce interface clutter. Also
make sure it becomes visible
+ // when selected. Similar to jquery.mw-jump
+ $( '<div>' ).addClass( 'mw-navigation-hint' )
+ .text( mw.msg( 'prefs-tabs-navigation-hint' ) )
+ .attr( 'tabIndex', 0 )
+ .on( 'focus blur', function ( e ) {
+ if ( e.type === 'blur' || e.type === 'focusout'
) {
+ $( this ).css( 'height', '0' );
+ } else {
+ $( this ).css( 'height', 'auto' );
+ }
+ } ).insertBefore( $preftoc );
+
+ /**
+ * It uses document.getElementById for security reasons (HTML
injections in $()).
+ *
+ * @ignore
+ * @param {string} name the name of a tab without the prefix
("mw-prefsection-")
+ * @param {string} [mode] A hash will be set according to the
current
+ * open section. Set mode 'noHash' to surpress this.
+ */
+ function switchPrefTab( name, mode ) {
+ var $tab, scrollTop;
+ // Handle hash manually to prevent jumping,
+ // therefore save and restore scrollTop to prevent
jumping.
+ scrollTop = $( window ).scrollTop();
+ if ( mode !== 'noHash' ) {
+ location.hash = '#mw-prefsection-' + name;
+ }
+ $( window ).scrollTop( scrollTop );
+
+ $preftoc.find( 'li' ).removeClass( 'selected' )
+ .find( 'a' ).attr( {
+ tabIndex: -1,
+ 'aria-selected': 'false'
+ } );
+
+ $tab = $( document.getElementById( 'preftab-' + name )
);
+ if ( $tab.length ) {
+ $tab.attr( {
+ tabIndex: 0,
+ 'aria-selected': 'true'
+ } )
+ .focus()
+ .parent().addClass( 'selected' );
+
+ $preferences.children( 'fieldset'
).hide().attr( 'aria-hidden', 'true' );
+ $( document.getElementById( 'mw-prefsection-' +
name ) ).show().attr( 'aria-hidden', 'false' );
+ }
+ }
+
+ // Check for messageboxes (.successbox, .warningbox, .errorbox)
to replace with notifications
+ if ( $( '.mw-preferences-messagebox' ).length ) {
+ // If there is a #mw-preferences-success box and
javascript is enabled, use a slick notification instead!
+ if ( $( '#mw-preferences-success' ).length ) {
+ var notif = mw.notification.notify( mw.message(
'savedprefs' ), { autoHide: false } );
+ // 'change' event not reliable!
+ $( '#preftoc, .prefsection' ).one( 'change
keydown mousedown', function () {
+ if ( notif ) {
+ notif.close();
+ notif = null;
+ }
+ } );
+
+ // Remove now-unnecessary success=1 querystring
to prevent reappearance of notification on reload
+ if ( history.replaceState ) {
+ history.replaceState( {},
document.title, location.href.replace( /&?success=1/, '' ) );
+ }
+ }
+ }
+
+ // Populate the prefToc
+ $legends.each( function ( i, legend ) {
+ var $legend = $( legend ),
+ ident, $li, $a;
+ if ( i === 0 ) {
+ $legend.parent().show();
+ }
+ ident = $legend.parent().attr( 'id' );
+
+ $li = $( '<li>' )
+ .attr( 'role', 'presentation' )
+ .addClass( i === 0 ? 'selected' : '' );
+ $a = $( '<a>' )
+ .attr( {
+ id: ident.replace( 'mw-prefsection',
'preftab' ),
+ href: '#' + ident,
+ role: 'tab',
+ tabIndex: i === 0 ? 0 : -1,
+ 'aria-selected': i === 0 ? 'true' :
'false',
+ 'aria-controls': ident
+ } )
+ .text( $legend.text() );
+ $li.append( $a );
+ $preftoc.append( $li );
+ } );
+
+ // Disable the button to save preferences unless preferences
have changed
+ $( '#prefcontrol' ).prop( 'disabled', true );
+ $( '.prefsection' ).one( 'change keydown mousedown', function
() {
+ $( '#prefcontrol' ).prop( 'disabled', false );
+ } );
+
+ // Enable keyboard users to use left and right keys to switch
tabs
+ $preftoc.on( 'keydown', function ( event ) {
+ var keyLeft = 37,
+ keyRight = 39,
+ $el;
+
+ if ( event.keyCode === keyLeft ) {
+ $el = $( '#preftoc li.selected' ).prev().find(
'a' );
+ } else if ( event.keyCode === keyRight ) {
+ $el = $( '#preftoc li.selected' ).next().find(
'a' );
+ } else {
+ return;
+ }
+ if ( $el.length > 0 ) {
+ switchPrefTab( $el.attr( 'href' ).replace(
'#mw-prefsection-', '' ) );
+ }
+ } );
+
+ // If we've reloaded the page or followed an open-in-new-window,
+ // make the selected tab visible.
+ if ( location.hash.match( /^#mw-prefsection-[\w\-]+/ ) ) {
+ switchPrefTab( location.hash.replace(
'#mw-prefsection-', '' ) );
+ }
+
+ // In browsers that support the onhashchange event we will not
bind click
+ // handlers and instead let the browser do the default behavior
(clicking the
+ // <a href="#.."> will naturally set the hash, handled by
onhashchange.
+ // But other things that change the hash will also be catched
(e.g. using
+ // the Back and Forward browser navigation).
+ // Note the special check for IE "compatibility" mode.
+ if ( 'onhashchange' in window &&
+ ( document.documentMode === undefined ||
document.documentMode >= 8 )
+ ) {
+ $( window ).on( 'hashchange', function () {
+ var hash = location.hash;
+ if ( hash.match( /^#mw-prefsection-[\w\-]+/ ) )
{
+ switchPrefTab( hash.replace(
'#mw-prefsection-', '' ) );
+ } else if ( hash === '' ) {
+ switchPrefTab( 'personal', 'noHash' );
+ }
+ } );
+ // In older browsers we'll bind a click handler as fallback.
+ // We must not have onhashchange *and* the click handlers,
other wise
+ // the click handler calls switchPrefTab() which sets the hash
value,
+ // which triggers onhashcange and calls switchPrefTab() again.
+ } else {
+ $preftoc.on( 'click', 'li a', function ( e ) {
+ switchPrefTab( $( this ).attr( 'href'
).replace( '#mw-prefsection-', '' ) );
+ e.preventDefault();
+ } );
+ }
+ // Preserve the tab after saving the preferences
+ // Not using cookies, because their deletion results are
inconsistent.
+ // Not using jStorage due to its enormous size (for this
feature)
+ if ( window.sessionStorage ) {
+ if ( sessionStorage.getItem( 'mediawikiPreferencesTab'
) !== null ) {
+ switchPrefTab( sessionStorage.getItem(
'mediawikiPreferencesTab' ), 'noHash' );
+ }
+ // Deleting the key, the tab states should be reset
until we press Save
+ sessionStorage.removeItem( 'mediawikiPreferencesTab' );
+
+ $( '#mw-prefs-form' ).submit( function () {
+ var storageData = $( $preftoc ).find(
'li.selected a' ).attr( 'id' ).replace( 'preftab-', '' );
+ sessionStorage.setItem(
'mediawikiPreferencesTab', storageData );
+ } );
+ }
+ } );
+}( mediaWiki, jQuery ) );
diff --git
a/resources/src/mediawiki.special/mediawiki.special.preferences.timezone.js
b/resources/src/mediawiki.special/mediawiki.special.preferences.timezone.js
new file mode 100644
index 0000000..c373a6f
--- /dev/null
+++ b/resources/src/mediawiki.special/mediawiki.special.preferences.timezone.js
@@ -0,0 +1,82 @@
+/*!
+ * JavaScript for Special:Preferences
+ */
+( function ( mw, $ ) {
+ $( function () {
+ // Timezone functions.
+ // Guesses Timezone from browser and updates fields onchange.
+ var $tzSelect, $tzTextbox, $localtimeHolder, servertime;
+
+ $tzSelect = $( '#mw-input-wptimecorrection' );
+ $tzTextbox = $( '#mw-input-wptimecorrection-other' );
+ $localtimeHolder = $( '#wpLocalTime' );
+ servertime = parseInt( $( 'input[name="wpServerTime"]' ).val(),
10 );
+
+ function minutesToHours( min ) {
+ var tzHour = Math.floor( Math.abs( min ) / 60 ),
+ tzMin = Math.abs( min ) % 60,
+ tzString = ( ( min >= 0 ) ? '' : '-' ) + ( (
tzHour < 10 ) ? '0' : '' ) + tzHour +
+ ':' + ( ( tzMin < 10 ) ? '0' : '' ) +
tzMin;
+ return tzString;
+ }
+
+ function hoursToMinutes( hour ) {
+ var minutes,
+ arr = hour.split( ':' );
+
+ arr[ 0 ] = parseInt( arr[ 0 ], 10 );
+
+ if ( arr.length === 1 ) {
+ // Specification is of the form [-]XX
+ minutes = arr[ 0 ] * 60;
+ } else {
+ // Specification is of the form [-]XX:XX
+ minutes = Math.abs( arr[ 0 ] ) * 60 + parseInt(
arr[ 1 ], 10 );
+ if ( arr[ 0 ] < 0 ) {
+ minutes *= -1;
+ }
+ }
+ // Gracefully handle non-numbers.
+ if ( isNaN( minutes ) ) {
+ return 0;
+ } else {
+ return minutes;
+ }
+ }
+
+ function updateTimezoneSelection() {
+ var minuteDiff, localTime,
+ type = $tzSelect.val();
+
+ if ( type === 'guess' ) {
+ // Get browser timezone & fill it in
+ minuteDiff = -( new Date().getTimezoneOffset()
);
+ $tzTextbox.val( minutesToHours( minuteDiff ) );
+ $tzSelect.val( 'other' );
+ $tzTextbox.prop( 'disabled', false );
+ } else if ( type === 'other' ) {
+ // Grab data from the textbox, parse it.
+ minuteDiff = hoursToMinutes( $tzTextbox.val() );
+ } else {
+ // Grab data from the $tzSelect value
+ minuteDiff = parseInt( type.split( '|' )[ 1 ],
10 ) || 0;
+ $tzTextbox.val( minutesToHours( minuteDiff ) );
+ }
+
+ // Determine local time from server time and minutes
difference, for display.
+ localTime = servertime + minuteDiff;
+
+ // Bring time within the [0,1440) range.
+ localTime = ( ( localTime % 1440 ) + 1440 ) % 1440;
+
+ $localtimeHolder.text( mw.language.convertNumber(
minutesToHours( localTime ) ) );
+ }
+
+ if ( $tzSelect.length && $tzTextbox.length ) {
+ $tzSelect.change( updateTimezoneSelection );
+ $tzTextbox.blur( updateTimezoneSelection );
+ updateTimezoneSelection();
+ }
+
+ } );
+}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/247728
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib58d2bf9fb4dbb32412adc29cd2384e106b2119a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: saper <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
