Kaldari has submitted this change and it was merged. Change subject: Correct the error count ......................................................................
Correct the error count the error count is off otherwise. Comment on that function says it was a bit hacky. This fix doesn't improve on that, but at least it gives me sensible error counts. To see the problem: choose two files to upload, select "provide individual licenses", the just click next on the describe step without entering descriptions or choosing a license. I got a message saying "There are 2 errors..." when the interface clearly showed me four. With this fix, the error count did in my manual tests match the actual number of errors displayed on the page. Change-Id: If0cb1ff2da002b62e1020d68d37d4c5fdd2e08e4 --- M resources/mw.UploadWizard.js 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Kaldari: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36602 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0cb1ff2da002b62e1020d68d37d4c5fdd2e08e4 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Lupo <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: Lupo <[email protected]> Gerrit-Reviewer: MarkTraceur <[email protected]> Gerrit-Reviewer: Nischayn22 <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
