Alexandros Kosiaris has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247822
Change subject: hiera: fix corner case in role backend
......................................................................
hiera: fix corner case in role backend
There is a corner case in the role backend when an empty yaml file is
accessed where "data" is nil and does not have an empty? method causing
a traceback and failing catalog compilation. Guard against that by
checking if data is nil.
Change-Id: Ica25cf4d84f0a61ceef71acf434357ec84646776
---
M modules/wmflib/lib/hiera/backend/role_backend.rb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/22/247822/1
diff --git a/modules/wmflib/lib/hiera/backend/role_backend.rb
b/modules/wmflib/lib/hiera/backend/role_backend.rb
index c7f46ba..c876340 100644
--- a/modules/wmflib/lib/hiera/backend/role_backend.rb
+++ b/modules/wmflib/lib/hiera/backend/role_backend.rb
@@ -139,7 +139,7 @@
YAML.load(content)
end
- next if data.empty?
+ next if data.nil? or data.empty?
next unless data.include? key
--
To view, visit https://gerrit.wikimedia.org/r/247822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica25cf4d84f0a61ceef71acf434357ec84646776
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
