jenkins-bot has submitted this change and it was merged.
Change subject: Do not double-parse 'cite_error_references_duplicate_key' error
message
......................................................................
Do not double-parse 'cite_error_references_duplicate_key' error message
This value is supposed to be wikitext, which will be parsed later,
not HTML ready for outputting.
Follow-up to 6c59f478050b6e9ca5aae4a445a4e87c9c16d256.
Bug: T116149
Change-Id: I6d6f474db7c7a075499f94301978572179975749
(cherry picked from commit 2e588a74241372231dc2b7e69961feccb18f8bcc)
---
M Cite_body.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Cite_body.php b/Cite_body.php
index cd42fb5..63917d4 100644
--- a/Cite_body.php
+++ b/Cite_body.php
@@ -460,7 +460,7 @@
if ( $str != null && $str !== '' && $str !==
$this->mRefs[$group][$key]['text'] ) {
// two refs with same key and different content
// add error message to the original ref
- $this->mRefs[$group][$key]['text'] .= ' ' .
$this->error( 'cite_error_references_duplicate_key', $key );
+ $this->mRefs[$group][$key]['text'] .= ' ' .
$this->error( 'cite_error_references_duplicate_key', $key, 'noparse' );
}
$this->mRefCallStack[] = array( 'increment', $call,
$str, $key, $group,
$this->mRefs[$group][$key]['key'] );
--
To view, visit https://gerrit.wikimedia.org/r/247840
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d6f474db7c7a075499f94301978572179975749
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: wmf/1.27.0-wmf.2
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
