Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247865
Change subject: ve.ce.Surface: Defer checkSequences call for insertText as well
......................................................................
ve.ce.Surface: Defer checkSequences call for insertText as well
Calling checkSequences before the current observation cycle
has finished can leave the mode and view out of sync.
Defer it like we do in handleLinearEnter.
Bug: T116180
Change-Id: I972c5b658e4ac5187c53c61eb7050e33f593305a
---
M src/ce/ve.ce.Surface.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/65/247865/1
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index ecbc785..6ff608b 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -2557,6 +2557,7 @@
ve.ce.Surface.prototype.handleObservedChanges = function ( oldState, newState
) {
var newSelection, dmContentChange,
+ surface = this,
dmDoc = this.getModel().getDocument(),
insertedText = false;
@@ -2623,7 +2624,9 @@
}
if ( insertedText ) {
- this.checkSequences();
+ setTimeout( function () {
+ surface.checkSequences();
+ } );
}
if ( newState.branchNodeChanged && newState.node ) {
this.updateCursorHolders();
--
To view, visit https://gerrit.wikimedia.org/r/247865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I972c5b658e4ac5187c53c61eb7050e33f593305a
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
