Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/247922
Change subject: Hygiene: make inner class static
......................................................................
Hygiene: make inner class static
Convert inner class, CabSearchView.PlainTextInputFilter, to a static
nested class and update comments. No functional changes intended.
Change-Id: Id77751d543f2c7b4483f98d6da04420e1d57ebaa
---
M app/src/main/java/org/wikipedia/richtext/RichTextUtil.java
M app/src/main/java/org/wikipedia/views/CabSearchView.java
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/22/247922/1
diff --git a/app/src/main/java/org/wikipedia/richtext/RichTextUtil.java
b/app/src/main/java/org/wikipedia/richtext/RichTextUtil.java
index 4fd0515..5e5e13f 100644
--- a/app/src/main/java/org/wikipedia/richtext/RichTextUtil.java
+++ b/app/src/main/java/org/wikipedia/richtext/RichTextUtil.java
@@ -37,13 +37,13 @@
}
}
- /** Strips all rich text except those used to provide compositional hints.
*/
+ /** Strips all rich text except spans used to provide compositional hints.
*/
public static CharSequence stripRichText(CharSequence str, int start, int
end) {
String plainText = str.toString();
SpannableString ret = new SpannableString(plainText);
if (str instanceof Spanned) {
- List<Object> keyboardHintSpans =
RichTextUtil.getComposingSpans((Spanned) str, start, end);
- RichTextUtil.copySpans((Spanned) str, ret, keyboardHintSpans);
+ List<Object> keyboardHintSpans = getComposingSpans((Spanned) str,
start, end);
+ copySpans((Spanned) str, ret, keyboardHintSpans);
}
return ret;
}
diff --git a/app/src/main/java/org/wikipedia/views/CabSearchView.java
b/app/src/main/java/org/wikipedia/views/CabSearchView.java
index 4f7a82e..73c0ebe 100644
--- a/app/src/main/java/org/wikipedia/views/CabSearchView.java
+++ b/app/src/main/java/org/wikipedia/views/CabSearchView.java
@@ -84,7 +84,7 @@
@Override public void onDestroyActionMode(ActionMode mode) { }
}
- private class PlainTextInputFilter implements InputFilter {
+ private static class PlainTextInputFilter implements InputFilter {
@Override
public CharSequence filter(CharSequence source, int start, int end,
Spanned dest,
int dstart, int dend) {
--
To view, visit https://gerrit.wikimedia.org/r/247922
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id77751d543f2c7b4483f98d6da04420e1d57ebaa
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
