[MediaWiki-commits] [Gerrit] Fix table headers on reports page to point to the right URL - change (wikimedia/iegreview)

[Niharika29 (Code Review)]

Niharika29 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/247977

Change subject: Fix table headers on reports page to point to the right URL
......................................................................

Fix table headers on reports page to point to the right URL

Changed incorrect campaign id param to the URL route
Bug: T116071

Change-Id: I82af835ba0afa00becb20c60dcb6df5d2afcb890
---
M data/templates/reports/report.html
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/iegreview 
refs/changes/77/247977/1

diff --git a/data/templates/reports/report.html 
b/data/templates/reports/report.html
index 40512c1..98da98d 100644
--- a/data/templates/reports/report.html
+++ b/data/templates/reports/report.html
@@ -29,7 +29,7 @@
 {% else %}
   {% set class = '' %}
 {% endif %}
-<th><a class="sortable {{ sorted ? "sorted-#{o}" : 'unsorted' }} {{ class }}" 
href="{{ urlFor( ctx.route, { 'campaign':campaign } ) }}?{{ qsMerge( { 
's':column, 'o':nextO } ) }}">{{ label }}</a></th>
+<th><a class="sortable {{ sorted ? "sorted-#{o}" : 'unsorted' }} {{ class }}" 
href="{{ urlFor( ctx.route, { 'campaign':ctx.campaign } ) }}?{{ qsMerge( { 
's':column, 'o':nextO } ) }}">{{ label }}</a></th>
 {% endmacro %}
 
 {% macro format( row, spec, ctx ) %}
@@ -66,7 +66,7 @@
 <ol class="breadcrumb">
   <li><a href="{{ urlFor( 'campaigns' ) }}">{{ 'nav-campaigns'|message 
}}</a></li>
   <li>{{ 'nav-reports'|message }}</li>
-  <li><a href="{{ urlFor( route, { 'campaign':campaign } ) }}">{{ ( 
'nav-reports-' ~ suffix )|message }}</a></li>
+  <li><a href="{{ urlFor( route, { 'campaign':ctx.campaign } ) }}">{{ ( 
'nav-reports-' ~ suffix )|message }}</a></li>
 </ol>
 
 <table class="table table-striped table-hover table-condensed 
table-responsive">
@@ -103,17 +103,17 @@
   <div class="col-md-9">
     <ul class="pagination">
       {% if p > 0 %}
-      <li><a href="{{ urlFor( route, { 'campaign':campaign } ) }}?{{ qsMerge( 
{ 'p':(p - 1) } ) }}" id="prev">&laquo;</a></li>
+      <li><a href="{{ urlFor( route, { 'campaign':ctx.campaign } ) }}?{{ 
qsMerge( { 'p':(p - 1) } ) }}" id="prev">&laquo;</a></li>
       {% else %}
       <li class="disabled"><span>&laquo;</span></li>
       {% endif %}
       {% if left > 0 %}<li class="disabled"><span>&hellip;</span></li>{% endif 
%}
       {% for i in left .. right %}
-      <li class="{{ i == p ? 'active' }}"><a href="{{ urlFor( route, { 
'campaign':campaign } ) }}?{{ qsMerge( { 'p':i } ) }}" id="prev">{{ i + 1 
}}</a></li>
+      <li class="{{ i == p ? 'active' }}"><a href="{{ urlFor( route, { 
'campaign':ctx.campaign } ) }}?{{ qsMerge( { 'p':i } ) }}" id="prev">{{ i + 1 
}}</a></li>
       {% endfor %}
       {% if right < pages - 1 %}<li 
class="disabled"><span>&hellip;</span></li>{% endif %}
       {% if p + 1 < pages %}
-      <li><a href="{{ urlFor( route, { 'campaign':campaign } ) }}?{{ qsMerge( 
{ 'p':(p + 1) } ) }}" >&raquo;</a></li>
+      <li><a href="{{ urlFor( route, { 'campaign':ctx.campaign } ) }}?{{ 
qsMerge( { 'p':(p + 1) } ) }}" >&raquo;</a></li>
       {% else %}
       <li class="disabled"><span>&raquo;</span></li>
       {% endif %}

-- 
To view, visit https://gerrit.wikimedia.org/r/247977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82af835ba0afa00becb20c60dcb6df5d2afcb890
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/iegreview
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <nihar...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits