Brian Wolff has uploaded a new change for review.
https://gerrit.wikimedia.org/r/248119
Change subject: Properly make LinksUpdate be recursive when done from job queue
......................................................................
Properly make LinksUpdate be recursive when done from job queue
New enqueue method of DeferredUpdates was turning LinksUpdate
updates into Jobs. However RefreshLinksJob was not properly
reconstructing the secondary updates as being recursive (if they
were recursive). This means that templates weren't having the pages
that were using them being updated.
See also related T116001.
Change-Id: Ia06246efb2034fdfe07232fd8c2334160edbcf02
---
M includes/deferred/LinksUpdate.php
M includes/jobqueue/jobs/RefreshLinksJob.php
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/19/248119/1
diff --git a/includes/deferred/LinksUpdate.php
b/includes/deferred/LinksUpdate.php
index 5a7efca..fa09b37 100644
--- a/includes/deferred/LinksUpdate.php
+++ b/includes/deferred/LinksUpdate.php
@@ -996,7 +996,8 @@
array(
'prioritize' => true,
// Reuse the parser cache if it was
saved
- 'rootJobTimestamp' =>
$this->mParserOutput->getCacheTime()
+ 'rootJobTimestamp' =>
$this->mParserOutput->getCacheTime(),
+ 'useRecursiveLinksUpdate' =>
$this->mRecursive
),
array( 'removeDuplicates' => true ),
$this->getTitle()
diff --git a/includes/jobqueue/jobs/RefreshLinksJob.php
b/includes/jobqueue/jobs/RefreshLinksJob.php
index 7093e14..1d59b32 100644
--- a/includes/jobqueue/jobs/RefreshLinksJob.php
+++ b/includes/jobqueue/jobs/RefreshLinksJob.php
@@ -197,7 +197,8 @@
}
}
- $updates = $content->getSecondaryDataUpdates( $title, null,
false, $parserOutput );
+ $updates = $content->getSecondaryDataUpdates(
+ $title, null, !empty(
$this->params['useRecursiveLinksUpdate'] ), $parserOutput );
foreach ( $updates as $key => $update ) {
if ( $update instanceof LinksUpdate && isset(
$this->params['triggeredRecursive'] ) ) {
$update->setTriggeredRecursive();
--
To view, visit https://gerrit.wikimedia.org/r/248119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia06246efb2034fdfe07232fd8c2334160edbcf02
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
