Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/248368
Change subject: Ensure memcached keys are valid ASCII
......................................................................
Ensure memcached keys are valid ASCII
Stop the flood of memcached key errors of the form:
memcached ERROR: Memcached error for key
"flowdb:flow_ref:url:by-source:v3:0:ruwiki:Сталинская_премия_за_выдающиеся_изобретения_и_коренные_усовершенствования_методов_производственной_работы_(1951):4.7"
on server ":": A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE
Change-Id: I26e531f63ff9abf6794b27c8d2c39633f0846c1e
---
M includes/Data/Index/FeatureIndex.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/68/248368/1
diff --git a/includes/Data/Index/FeatureIndex.php
b/includes/Data/Index/FeatureIndex.php
index 52a3600..6eec95e 100644
--- a/includes/Data/Index/FeatureIndex.php
+++ b/includes/Data/Index/FeatureIndex.php
@@ -693,7 +693,7 @@
// which would lead to differences in cache key if we don't
force that
sort( $attributes );
- return wfForeignMemcKey( self::cachedDbId(), '', $this->prefix,
implode( ':', $attributes ), Container::get( 'cache.version' ) );
+ return wfForeignMemcKey( self::cachedDbId(), '', $this->prefix,
md5( implode( ':', $attributes ) ), Container::get( 'cache.version' ) );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/248368
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26e531f63ff9abf6794b27c8d2c39633f0846c1e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
