Wikinaut has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/248479

Change subject: Suppress delete button (icon) if history is empty
......................................................................

Suppress delete button (icon) if history is empty

Change-Id: I71e0437fb92497e1c7c12e1c5faa84e0eff58ba0
---
M app/src/main/java/org/wikipedia/history/HistoryFragment.java
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/79/248479/1

diff --git a/app/src/main/java/org/wikipedia/history/HistoryFragment.java 
b/app/src/main/java/org/wikipedia/history/HistoryFragment.java
index 5eecf48..bfddbef 100644
--- a/app/src/main/java/org/wikipedia/history/HistoryFragment.java
+++ b/app/src/main/java/org/wikipedia/history/HistoryFragment.java
@@ -312,7 +312,9 @@
         if (!isAdded() || ((PageActivity)getActivity()).isSearching()) {
             return;
         }
-        
menu.findItem(R.id.menu_clear_all_history).setEnabled(historyEntryList.getCount()
 > 0);
+        menu.findItem(R.id.menu_clear_all_history)
+            .setVisible(historyEntryList.getCount() > 0)
+            .setEnabled(historyEntryList.getCount() > 0);
     }
 
     @Override

-- 
To view, visit https://gerrit.wikimedia.org/r/248479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I71e0437fb92497e1c7c12e1c5faa84e0eff58ba0
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Wikinaut <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to