Physikerwelt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/248626
Change subject: Update while style iterators
......................................................................
Update while style iterators
* Explicitly check if assignment operation yields false
Change-Id: I5c254c4b4765fc765cca15babf2b403ba413bce0
---
M includes/ImportCsv.php
M includes/MathSearchTerm.php
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MathSearch
refs/changes/26/248626/1
diff --git a/includes/ImportCsv.php b/includes/ImportCsv.php
index ec7c113..426d4e0 100644
--- a/includes/ImportCsv.php
+++ b/includes/ImportCsv.php
@@ -128,7 +128,7 @@
$table = array();
- while ( $line = fgetcsv( $csv_file ) ) {
+ while ( ( $line = fgetcsv( $csv_file ) ) !== false ) {
array_push( $table, $line );
}
fclose( $csv_file );
diff --git a/includes/MathSearchTerm.php b/includes/MathSearchTerm.php
index afdf66f..329ca1d 100644
--- a/includes/MathSearchTerm.php
+++ b/includes/MathSearchTerm.php
@@ -92,7 +92,7 @@
$search->setLimitOffset( 10000 );
$sres = $search->searchText( $this->getExpr() );
if ( $sres ) {
- while ( $tres = $sres->next() ) {
+ while ( ( $tres = $sres->next() ) !==
false ) {
$revisionID =
$tres->getTitle()->getLatestRevID();
$this->resultSet[(string)$revisionID] = $tres;
$this->relevanceMap[] =
$revisionID;
--
To view, visit https://gerrit.wikimedia.org/r/248626
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c254c4b4765fc765cca15babf2b403ba413bce0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
