Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/248656

Change subject: Fix HockeyApp ProGuard rules
......................................................................

Fix HockeyApp ProGuard rules

* Fix HockeyApp ProGuard rules. The old rules don't seem to work any
  more. Blanket keep all in the HockeyApp package.
* Check for crashes in PageActivity. When transmission of the crash
  report fails in CrashReportActivity, the report lingers until the next
  check. Always check in PageActivity so we get reports as soon as
  possible.

Change-Id: I3450136cb849b647169de1cbe06a7127026dff2e
---
M app/proguard-rules.pro
M app/src/main/java/org/wikipedia/page/PageActivity.java
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/56/248656/1

diff --git a/app/proguard-rules.pro b/app/proguard-rules.pro
index 720ec12..298cd36 100644
--- a/app/proguard-rules.pro
+++ b/app/proguard-rules.pro
@@ -88,7 +88,8 @@
 
 # This is undocumented but seems to work.
 -dontwarn uk.co.senab.photoview.**
-
+-keep class net.hockeyapp.** { <init>(...); *; }
+-keep enum net.hockeyapp.** { <init>(...); *; }
 # --- /HockeyApp ---
 
 # --- Mapbox ---
diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java 
b/app/src/main/java/org/wikipedia/page/PageActivity.java
index 8f0bfb3..df7cfe6 100644
--- a/app/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/app/src/main/java/org/wikipedia/page/PageActivity.java
@@ -179,6 +179,7 @@
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         app = (WikipediaApp) getApplicationContext();
+        app.checkCrashes(this);
 
         PreferenceManager.setDefaultValues(this, R.xml.preferences, false);
         setContentView(R.layout.activity_page);

-- 
To view, visit https://gerrit.wikimedia.org/r/248656
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3450136cb849b647169de1cbe06a7127026dff2e
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to