ArielGlenn has submitted this change and it was merged.
Change subject: dumps: don't escape commands not run in shell
......................................................................
dumps: don't escape commands not run in shell
Change-Id: Ifb02b47199403e4ecc5211da5f683620369ef349
---
M xmldumps-backup/dumps/fileutils.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
ArielGlenn: Looks good to me, approved
jenkins-bot: Verified
diff --git a/xmldumps-backup/dumps/fileutils.py
b/xmldumps-backup/dumps/fileutils.py
index 22bb4ab..ab175f7 100644
--- a/xmldumps-backup/dumps/fileutils.py
+++ b/xmldumps-backup/dumps/fileutils.py
@@ -281,7 +281,7 @@
raise BackupError("head command %s not found" %
self._wiki.config.head)
head = self._wiki.config.head
head_esc = MiscUtils.shellEscape(head)
- pipeline.append([head_esc, "-500"])
+ pipeline.append([head, "-500"])
# without shell
proc = CommandPipeline(pipeline, quiet=True)
proc.run_pipeline_get_output()
--
To view, visit https://gerrit.wikimedia.org/r/244799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb02b47199403e4ecc5211da5f683620369ef349
Gerrit-PatchSet: 1
Gerrit-Project: operations/dumps
Gerrit-Branch: ariel
Gerrit-Owner: ArielGlenn <[email protected]>
Gerrit-Reviewer: ArielGlenn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
