Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/248830
Change subject: Use listview.removeItem for reference removing in statementview
......................................................................
Use listview.removeItem for reference removing in statementview
`removeItem` triggers an event which is captured in `statementview` to update
the references counter.
Change-Id: I05d88246c2c0c61dbb22f517536b55bb8e321ef4
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/30/248830/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index d445306..3479e2e 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -328,9 +328,7 @@
$newLi
.on( lia.prefixedEvent( 'afterstopediting' ),
function( event, dropValue ) {
if ( dropValue ) {
- liInstance.destroy();
- $newLi.remove();
- self._drawReferencesCounter();
+
self._referencesListview.removeItem( $newLi );
} else {
var newReferenceWithHash =
liInstance.value();
--
To view, visit https://gerrit.wikimedia.org/r/248830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05d88246c2c0c61dbb22f517536b55bb8e321ef4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
